? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
7 Dec 2014

This PR optimizes the batch process and removes a lot of duplicate code. It adds 2 new variables that let you define the tasks to do and a copymove task before those additional tasks. That copymove task might modify the IDs of the items to treat and thus needs to be handled differently.

This modification is backwards compatible. To test, please simply check that all batch processes in all combinations still work.

It would be preferable if #5317 would be merged first. This PR is based on those changes and will automatically adapt if #5317 is merged.

avatar Hackwar Hackwar - open - 7 Dec 2014
avatar jissues-bot jissues-bot - change - 7 Dec 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 8 Dec 2014

#5317 merged. This PR does not apply anymore here (with eclipse)

avatar Hackwar
Hackwar - comment - 8 Dec 2014

Now it should work. :wink:

avatar smanzi
smanzi - comment - 9 Dec 2014

@test success
tested in com_modules and com_content with all options permutations I can think of...

avatar smanzi smanzi - test_item - 9 Dec 2014 - Tested successfully
avatar Kubik-Rubik Kubik-Rubik - test_item - 10 Dec 2014 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Dec 2014

Tested successfully!

Thank you, @Hackwar!

Tested batch functions in: Banners, Contact, Menu, Modules and Content

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.

avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2014
Status Pending Ready to Commit
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Dec 2014

A side note: The copy function in the batch process for menu entries still doesn't work, the entries are moved, not copied! Can somebody confirm it?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.

avatar Hackwar
Hackwar - comment - 10 Dec 2014

Thank you to @smanzi and @Kubik-Rubik

avatar Hackwar
Hackwar - comment - 10 Dec 2014

Just to clarify: That issue with the copy function is unrelated to this PR.

avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Dec 2014

Yes, it has nothing to do with this PR! This PR is ready to be committed. :+1:

avatar infograf768
infograf768 - comment - 10 Dec 2014

Works fine here. Merging.

avatar infograf768 infograf768 - close - 10 Dec 2014
avatar infograf768 infograf768 - change - 10 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-10 18:11:05

Add a Comment

Login with GitHub to post a comment