[#5300] - Fix for issue #5286 "UX Issue: Error message should display in Red color instead of green text"
- Closed
- 8 Dec 2014
- Medium
- Build: staging
- # 5300
- Diff
- big-wave-tim:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a fix for Issue #5286 "Fix for UX Issue: Error message should display in Red color instead of green text"
Call to enqueueMessage didn't have a message type passed to it. As a result enqueueMessage was defaulting to type 'message' (green message box) irrespective of the installation outcome.
Fix - introduced $msgType variable which is set according to installation outcome just after the $msg is initialised.
Recreated error on local joomla installation. Removed files from a Joomla components zip file, installed Joomla component via "Upload Package File" method, installation failed with green message box.
Tested installing via "Upload Package File" with both correct and broken zip files, all functioned as expected.
First pull request ever so please forgive any mistakes!!
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Rel_Number | ⇒ | 5286 | |
| Relation Type | ⇒ | Related to |
P.S. I have tested on a clean 3.4.0 Alpha with a hacked xmap container, so please nobody shall think this normally happens when installing xmap
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5300.
| Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5300.
| Labels |
Added:
?
|
||
Thanks.
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-08 07:42:06 |
| Labels |
Removed:
?
|
||
I have tested this with success, see following screenshots:
1. Without this PR
2. With this PR
@test OK