? Success

User tests: Successful: Unsuccessful:

avatar smanzi
smanzi
25 Nov 2014

This fixes the second of the issues I exposed in #5204

The problem was with the use of PHP strip_tags()

Using it a string of the kind <h1>Title</h1><p>This is the paragraph</p> is translated to:
TitleThis is the paragraph

Adding a space after each > does the trick...

avatar smanzi smanzi - open - 25 Nov 2014
avatar jissues-bot jissues-bot - change - 25 Nov 2014
Labels Added: ?
avatar smanzi
smanzi - comment - 25 Nov 2014

Sorry, I hit return by mistake and the initial comment wasn't already entered. As Jssues doesn't updates modification done in GitHub I'm forced to repeat it here:

This fixes the second of the issues I exposed in #5204

The problem was with the use of PHP strip_tags()

Using it a string of the kind <h1>Title</h1><p>This is the paragraph</p> is translated to:
TitleThis is the paragraph

Adding a space after each > does the trick...

avatar smanzi smanzi - change - 25 Nov 2014
Title
Fixes Issues in "Smart Search" [(see #5204)
Fixes Issues in "Smart Search" [#5204)
avatar smanzi smanzi - change - 25 Nov 2014
Title
Fixes Issues in "Smart Search" [#5204)
Fixes Issues in "Smart Search" [#5204]
avatar dgt41
dgt41 - comment - 25 Nov 2014

@smanzi put a space after each , to make travis happy

avatar chrisdavenport
chrisdavenport - comment - 25 Nov 2014

This probably fixes your immediate issue, but there are other issues with the parser that also need resolving. I have some untested code that I wrote a while back that I'll try to dig out that I think should fix the parser properly.

avatar smanzi smanzi - change - 25 Nov 2014
The description was changed
Title
Fixes Issues in "Smart Search" [(see #5204)
Fixes Issues in "Smart Search" [#5204]
avatar smanzi
smanzi - comment - 25 Nov 2014

@chrisdavenport I know and I agree! This thing indexes even things like "itemid"!!! If you have better code ready, please feel free to submit it: I'll promptly retract this PR, but in the meanwhile I think it is a small step forward indexing something with more sense...

avatar smanzi
smanzi - comment - 25 Nov 2014

@dgt41 tnx, Dimitris! Should be OK now...

avatar brianteeman brianteeman - change - 26 Nov 2014
Category Search
avatar chrisdavenport
chrisdavenport - comment - 7 Dec 2014

@smanzi @dgt41 I finally found my parser code and did a few tweaks to get it to work correctly. See #5340. Please test if you have time. Thanks.

avatar smanzi
smanzi - comment - 7 Dec 2014

That's great news, Chris!
I will test it ASAP ( I need to pull some content into my test site...)
Thanks!

avatar smanzi smanzi - close - 8 Dec 2014
avatar smanzi
smanzi - comment - 8 Dec 2014

Closing in favor of #5340 !

avatar smanzi smanzi - close - 8 Dec 2014
avatar smanzi smanzi - change - 8 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-08 00:41:08
avatar smz smz - head_ref_deleted - 25 Dec 2014

Add a Comment

Login with GitHub to post a comment