? Success

User tests: Successful: Unsuccessful:

avatar amazeika
amazeika
25 Nov 2014

The context being generated for triggering save events is currently malformed due to a un-noticed typo introduced on our PR #4308.

The context is currently being generated using:

$context    = $this->option . '_' . $this->name;

instead of:

$context    = $this->option . '.' . $this->name;

This PR solves this problem.

I'm really sorry for the trouble.

Thank you for taking the time to consider this PR.

avatar amazeika amazeika - open - 25 Nov 2014
avatar jissues-bot jissues-bot - change - 25 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 25 Nov 2014

Thanks for the fix. As it's an obvious one (once spotted) I'm going to merge it based on review

avatar Bakual Bakual - close - 25 Nov 2014
avatar Bakual Bakual - change - 25 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-25 18:32:45
avatar amazeika
amazeika - comment - 25 Nov 2014

@Bakual Thank you Thomas for the quick merge. I apologize again for this.

avatar Bakual
Bakual - comment - 25 Nov 2014

No problem, it happens to the best :smile:

avatar phproberto
phproberto - comment - 25 Nov 2014

Thanks @amazeika :dancer:

Add a Comment

Login with GitHub to post a comment