? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Nov 2014

This fixes #5179. We currently have 2 places where class aliases are registered, once in /libraries/classmap.php and once in /libraries/cms.php. I decided to only call class_alias() directly for JAdministrator, JSite and JRegistry, since those 3 classes are classes that are passed between extensions and objects. This always loads those 3 classes on every pageload, but I hope that downside is negligible. All other classes are extremely likely to be instantiated first and then checked against, which is why I doubt that we need to care for those separately. Basically, all JRegistry* classes are only used internally of JRegistry and JStringInflector seems to be a class that most likely is not created by the CMS and then used by an extension. JStringNormalise is abstract anyway, so this should not be a problem either.

avatar Hackwar
Hackwar - comment - 24 Nov 2014

Please remember that this solution is only viable for this specific situation. We can't do the aliasing stuff for other classes in the future.

avatar jissues-bot jissues-bot - close - 25 Nov 2014
avatar jissues-bot
jissues-bot - comment - 25 Nov 2014

Set to "closed" on behalf of @wilsonge by The JTracker Application at issues.joomla.org/joomla-cms/5184

avatar wilsonge
wilsonge - comment - 25 Nov 2014

I'm going to close this for the more generic fix in #5189 :) Thanks tho Hannes!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5184.

avatar Hackwar Hackwar - head_ref_deleted - 10 Dec 2014

Add a Comment

Login with GitHub to post a comment