?
avatar smanzi
smanzi
23 Nov 2014

The "Clear" button ("X") for several "Search" fields (e.g.: "Plugin Manager" and "Extensions Manager") is not functioning.

avatar smanzi smanzi - open - 23 Nov 2014
avatar dgt41
dgt41 - comment - 23 Nov 2014

There is already a proposed PR: #4895 Apply that patch and functionality will be restored.

This is due to #4888 and the absence of #4895. In #4888 we removed mootools calls from the toolbar buttons. The links that are failing in many pages is the result of the absence of mootools. Admin area was always dependent on mootools but this, shouldn’t be the case for 3rd party components.
What is failing here is that the buttons or links are using document.id(‘something’); and instead should be using vanilla javascript:

screen shot 2014-11-24 at 12 41 08

There was another report for this but I guess it shouldn’t be closed.
Sergio can you change the title here to something like: javascript errordocument.id(‘something’); is failing?
Thanks

avatar smanzi
smanzi - comment - 23 Nov 2014

Confirmed! Applying #4895 does solve this issue!
Jumping to give an @test for #4895... This MUST be merged! :smile:
Should I close this or leave it as a reminder?

avatar smanzi
smanzi - comment - 23 Nov 2014

No need of an @test: it is already RTC, but it seems to lack the milestone...

avatar dgt41
dgt41 - comment - 23 Nov 2014

Better leave it but can you change the title to something more generic as I proposed in the previous post?
I suspect if you close this I will have to write an answer again

avatar smanzi
smanzi - comment - 23 Nov 2014

@dgt41 Done: changed the title!

avatar dgt41
dgt41 - comment - 23 Nov 2014

:+1:

avatar smanzi
smanzi - comment - 23 Nov 2014

@dgt41 ... but this is not reflected in Jssues... :disappointed:

avatar mbabker
mbabker - comment - 23 Nov 2014

Unfortunately edits don't get synced across right away because GitHub's API doesn't send out data anymore when that happens. We have some cron jobs that should be taking care of this.

avatar dgt41
dgt41 - comment - 29 Nov 2014

@infograf768 you can close this one, since #4895 is merged. Thanks

avatar infograf768 infograf768 - change - 29 Nov 2014
Title
Clear button for Search ("Plugin Manager", "Extension Manager", etc.) not functioning
javascript errordocument.id(‘something’); is failing
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-11-29 09:08:24
avatar infograf768 infograf768 - close - 29 Nov 2014
avatar zero-24 zero-24 - close - 29 Nov 2014
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment