This seems to be the tabs js here.
Go to the install from URL (last tab)
Clear the local storage
Navigate elsewhere and then return to http://localhost/administrator/index.php?option=com_installer
JS error
Clear your browsers console
Go to the install from URL (last tab)
Navigate elsewhere and then return to http://localhost/administrator/index.php?option=com_installer
No error!

This must be due to changes for the sidebar because in my console I get:

undefined is not a function (evaluating 'value.removeClass('active')’)

What I get when accessing the first tab is: TypeError: value.removeClass is not a function

Try to test this
Go to /plugins/installer/webinstaller/webinstaller.php
replace lines 125-127 with:

jQuery('#myTabTabs li').parent().find(‘li').removeClass("active”);

@smanzi Can you make a PR with that?

Yep... but this is not in Joomla!! This is pulled when one accept to have the web installer...

Sorry forgot to tell you that it has to be against https://github.com/joomla-extensions/install-from-web-client

... and your fix does break the whole thing here: no more tabs in Extension Manager!

If you have working code, send me the whole file via email, I'll take care of the rest...

are you on Skype?

yes, wait

Delete this 3 lines and place the code above!

PR on its way... (after testing that it does not break 3.3.6...)

Someone please help: the code available at https://github.com/joomla-extensions/install-from-web-client is version 1.1.0, while the version pulled by joomla 3.4.0 Alpha when one accept to install "Install from Web" is version 1.0.5

• Is there a mistake in what 3.4.0 pulls?
• where is the repo for 1.0.5?

@mbabker any idea why we have older version shipping with 3.4? The repo seems to have 1.1.0 as current...

The update server that gets read is still showing 1.0.5 as the latest version, so that's what Joomla is picking up. See http://appscdn.joomla.org/webapps/jedapps/webinstaller.xml

So if they have tagged a new release, that XML file needs updating.

There are 0 tag releases in that repo. You know who’s in charge for this?

@beat I believe this is your team?

I have a PR (code by @dgt41) ready, but that repo with 1.1.0 in it has a lot of stuff that doesn't apply (even jQuery.js, tu support Joomla! 2.5) in it...

OK, PR is joomla-extensions/install-from-web-client#6 but as I said I'm unsure if the repo is the good one.

Code working on 3.4.0 Alpha
To be tested with older revs...

@smanzi just in case someone doesn’t like the change made here this is also working:

            jQuery('#myTabTabs ul>li').each(function(index, value){
                value.removeClass('active');
            });

@dgt41 Pushed!

and tested OK here.

@test latest version works for me - what has to be done now for that version to be the one that is installed @beat

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

@dgt41 Good solution, tested successfully!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

@mbabker + @brianteeman Thanks for the pings and sorry for the little delay in replying, was drawn under water of work last days.

Started the AppStore team on that PR joomla-extensions/install-from-web-client#6

@dgt41 Thanks for the fixing PR proposal: At first glance and before deeper review, wondering why making the jquery css selector more selective solves the issue, but maybe you can reply directly on the PR 6 linked above ? Are you sure that this would not be a workaround for the real bug that seems at very first glance to be in the tabs handler of Joomla 3.4 (and thus a B/C) ? (not wanting to push any fault nor work, but just want to understand why that javascript fatal error is triggered by (at first glance) just adding a class to the dom ?)

closing this here as it is being handled at http://joomla-extensions/install-from-web-client#6

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

Set to "closed" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/5180

@brianteeman This is a bug of Joomla 3.4. The workaround proposal at http://joomla-extensions/install-from-web-client#6 is just a workaround hiding this Joomla bug. Think this one should not be closed (even if the workaround is being code-reviewed by AppStore Team and could be included in the next update).

OK I am reopening but this needs to be solved by someone ad I dont care who that it is but its a showstopper. Raising priority

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

Set to "open" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/5180

I would love to have a look but can't reproduce it on my testing servers with current staging. Tried with Chrome and IE11 and on two different servers (Linux and Windows).

@beat I come to a conclusion after testing many different things here that the problem here is not the extra selector that I put on the script but the fact that sidebar is also using local storage and somehow this conflicts with the tabs. If someone can verify this maybe we can fix it in the root e.g. core.js.
Clear your local storage data
Enable debug and comment out lines 229, 248, 263 in media/system/core-uncompressed.js
The problem should not exist!

@beat @Bakual and anyone that follows this

I found a solution that doesn’t require any changes in webinstaller, only a minor in core.js (the sidebar stuff)
Instead of

        // Load the value from localStorage
        if (typeof(Storage) !== "undefined")
        {
            var $visible = localStorage.getItem(context);
        }

we can safely use this:

        // Load the value from localStorage
        if (!!localStorage.getItem)
        {
            var $visible = localStorage.getItem(context);
        }

In all three different places the code uses typeof(Storage) !== “undefined”

Can someone confirm that?

@dgt41 I was willing to give your solution a try, but... I don't have the issue anymore!
I've tried uninstalling and reinsatalling "Install from Web" a couple of times, but... no way!
Are you still on the originally released alpha or do you have the latest "staging" code?
I've updated to the latest staging this morning (for other reasons)...

No I am on alpha...

Actually I have also the staging but you are right only 3.4Alpha has the problem

I think something changed: I can't swear on that, but I've seen a correction this morning that COULD be related...
do you have the link for downloading the original alpha at hand?

Isn’t it this one https://github.com/joomla/joomla-cms/releases

silly me! hold on, I download, compare and let you know...

hhhmmm... can't find the diff that jumped to my eye this morning: it was the concatenation of two strings, something that went from:

$result = $string1 . '_' . $string2;

to

$result = $string1 . '.' . $string2;

... or vice-versa...

You mean this ?

YES!

anything to do with this? I was surprised because I couldn't relate it to any recently view PR...

And we have a winner here!
Congrats @smanzi
The problem here is not sidebar’s js or web installer js it was a conflict with this #5205, and since this is already merged in the staging I'll say to close this one!

... pure luck! (...or nose!)

should I close this?

YES

... and I'll also close the PR for "Install for Web"!

Sorry it is not fixed for me.
I redownloaded the current staging and installed the plugin.It just sits
their saying loading
However as soon as you leave the tab and return to it then it magically has
appeared
See https://www.dropbox.com/s/r0e69j7vhnuspcf/tab.mp4?dl=0

On 27 November 2014 at 22:51, Dimitris Grammatiko notifications@github.com
wrote:

oops... Strange? Have you tried uninstalling "Install from Web" and the install it back again?

Set to "open" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/5180

That was on a CLEAN intall

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

OK... Don't know what to say....

@brianteeman can you please try my solution on core.js few comments above?

no change - sorry - and bedtime for me

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5180.

@dgt41 I can confirm Brian issue: same s**t on fresh install...
I'm going to try your solution...

@smanzi Please make sure to replace all three instances of if (typeof(Storage) !== "undefined”)
with if (!!localStorage.getItem)
I tested and it even works on IE8!

f**k, it is minified... can you send me your copy by Skype? Opening now...

just copy the uncompressed from core-uncompressed.js and then make the changes...

no change for me - you have to click off the tab for it to work - that was
in a new browser with empty cache

On 27 November 2014 at 23:19, Dimitris Grammatiko notifications@github.com
wrote:

@smanzi https://github.com/smanzi Please make sure to replace all three
instances of if (typeof(Storage) !== "undefined”)
with if (!!localStorage.getItem)
I tested and it even works on IE8!

—
Reply to this email directly or view it on GitHub
#5180 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@dgt41 OK, and... HAPPY BIRTHDAY!!!

Thanks Sergio! But my solution is not actually a solution. Back to zero here!

Confirmed: it is not.... Installed from scratch (but with your core.js) and I still have the issue... WTF!, but WHY it had disappeared, before???

2 errors in console:

Empty string passed to getElementById(). jquery.min.js:2
TypeError: value.removeClass is not a function

Anyway, the behavior is now different: when I first opened this issue the "Install from Web" tab HAD to be put last to see it working. Now it is enough to click on another tab and the go back to it and it will work.

OK Had enough here
Lets simplify this to one line

jQuery('#myTabTabs').find('li').removeClass("active”);

AND call it a day or keep on searching why the current jQuery lines are not behaving sensible!

Do you want me to change that in joomla-extensions/install-from-web-client#6 ?

... and agree: had enough of this!

... and shouldn't it be each() instead of find() ?

One line is better than three and also indexing a list of maximum 5 elements is not gonna give efficiency or performance boost.

OK: going to change, then!

And by the way the current code that web installer is using is miracle that is working so far. Take a look here

... isn't li missing in your JSFiddle jQuery() script?

You can add it and still get the error! WE are looking that something else is wrong when in the first place the actual code here is not functional!

Confirmed! And your code run smoothly...

TypeError: value.removeClass is not a function ... I've seen that before...

The old code could also work

jQuery('#myTabTabs li').each(function(index, value){
                jQuery(value).removeClass('active');
            });

demo: http://jsfiddle.net/13ppwk5t/3/

it "runs", but it doesn't remove the "active" class...

Sorry Sergio I posted the wrong link. updated!

At this point I'm wondering if removing "active" is needed at all...

I’ll dream about it…

ahahahhahah! I hope you'll have better dreams!!!

This has been solved. Closing issue.