? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
23 Nov 2014

This is a fix for #5141

What this does: it moves the debug div into main content.
Also a minor stylistic touch on <code>

It looks like this:
screen shot 2014-11-23 at 3 30 33

Testing

Apply #5141
Apply this
Enable debug
Navigate around
Disable debug, enable debug language
Navigate around

avatar dgt41 dgt41 - open - 23 Nov 2014
avatar jissues-bot jissues-bot - change - 23 Nov 2014
Labels Added: ?
f375c41 23 Nov 2014 avatar dgt41 Init
avatar dgt41 dgt41 - change - 23 Nov 2014
The description was changed
avatar Bakual
Bakual - comment - 23 Nov 2014

Looks quite hackish to me, using JavaScript to move the debug output into another place.
To me it feels like a wrong approach to fix another issue (the sidebar).

avatar dgt41
dgt41 - comment - 23 Nov 2014

Indeed it is, but have you got something else to propose? (debug parses the html and replaces the </body> to inject the data)

avatar JoomliC
JoomliC - comment - 23 Nov 2014

Hi @dgt41, i will update in a few minutes #5141
Don't know why, but after a good week-end, and thinking of all your proposals, i've maybe found a solution, without edit of index.php nor debug changes ;-)

Will post on the other PR when this one updated!
Keep in touch! :+1:
Cyril

avatar Bakual
Bakual - comment - 23 Nov 2014

Indeed it is, but have you got something else to propose? (debug parses the html and replaces the </body> to inject the data)

That's no argument for me. Current sidebar works fine. The PR (sidebar styling) which causes the issue you want to fix here isn't merged yet. So I'd rather don't merge the styling PR than making such hacks to accomodate said styling. Better fix the styling then.
Or do I miss something?

avatar dgt41 dgt41 - close - 23 Nov 2014
avatar dgt41
dgt41 - comment - 23 Nov 2014

@Bakual This was like a band aid till we get it right.
Actually I thought we were in a rush to push that PR… ????
I guess I can close this one and let @JoomliC make the changes in the css...

avatar dgt41 dgt41 - close - 23 Nov 2014
avatar dgt41 dgt41 - change - 23 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-23 18:35:12
avatar dgt41
dgt41 - comment - 23 Nov 2014

@JoomliC Since you are there can you also push these two lines in /media/cms/css/debug.css:

  • white-space: pre;
  • word-wrap: break-word; Add them after line 115

Is a minor change for <code> #system-debug code so pages won’t get too wide!

avatar Bakual
Bakual - comment - 23 Nov 2014

Actually I thought we were in a rush to push that PR…

If you're going to rush things, you can be sure that it will not be merged. :wink:

avatar JoomliC
JoomliC - comment - 23 Nov 2014

@dgt41 i agree that we need sometimes to be sure, before to rush. The sidebar was a long job for many persons (love when community works together! :100: ) due to opinions, tastes, ideas, design sensibilities...
I've just udpated #5141 and new tests are really welcomed, as i think now, we have a pretty good sidebar! :+1:

About /media/cms/css/debug.css, it's not related to sidebar, so i would suggest just to keep opened this PR, and update it with only the css change.

I will test it of course ;-)

avatar dgt41 dgt41 - head_ref_deleted - 30 Nov 2014

Add a Comment

Login with GitHub to post a comment