User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Indeed it is, but have you got something else to propose? (debug parses the html and replaces the </body>
to inject the data)
Indeed it is, but have you got something else to propose? (debug parses the html and replaces the
</body>
to inject the data)
That's no argument for me. Current sidebar works fine. The PR (sidebar styling) which causes the issue you want to fix here isn't merged yet. So I'd rather don't merge the styling PR than making such hacks to accomodate said styling. Better fix the styling then.
Or do I miss something?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-23 18:35:12 |
Actually I thought we were in a rush to push that PR…
If you're going to rush things, you can be sure that it will not be merged.
@dgt41 i agree that we need sometimes to be sure, before to rush. The sidebar was a long job for many persons (love when community works together! ) due to opinions, tastes, ideas, design sensibilities...
I've just udpated #5141 and new tests are really welcomed, as i think now, we have a pretty good sidebar!
About /media/cms/css/debug.css, it's not related to sidebar, so i would suggest just to keep opened this PR, and update it with only the css change.
I will test it of course ;-)
Looks quite hackish to me, using JavaScript to move the debug output into another place.
To me it feels like a wrong approach to fix another issue (the sidebar).