User tests: Successful: Unsuccessful:
There were a bunch of non-printable characters in the SQL files, they are not needed. This PR cleaned them up.
Testing
Install the sample data and check if all the texts are still there.
Labels |
Added:
?
|
@infograf768 Ah yes, the \r\n that is not something I removed. I removed some funky  characters. I agree the \r\n can be removed as they have no meaning in HTML. I will update the PR.
As far as I can see here, the patch concerns only the sql
Correct I can see that from the code changes. I promised you yesterday to make a note so I just did :)
@infograf768 @gwsdesk Can you please test and let me know if you encounter any issues? Thanks.
@roland-d Still having this after applying patch (cleared caching ) See here http://gwsdev5.info/
The ID to look for is #5174 that is this patch. The #5195/#5196/#5197 numbers you mentioned are by another user for other fixes.
After applying the patch with the patch tester, you will have to do a new install by removing the configuration.php. Just applying the patch won't change what is already in the database. Did you do a new installation?
Oh you removed the installation folder already? In the alpha you don't have to remove it, the check for the installation folder is still disabled. What you can do, is copy the installation folder from the zipped file into your existing installation excluding the installation/sql/ folder and then start the installation. If you prefer a complete zipfile, let me know and I can create one.
OK for me in sql.
May need to correct the absence of space after period in sample blog
"This is a contact form which you can edit in the contact manager.Put your address or other information here. etc.
Thanks @infograf768 Added the missing space.
@roland-d , @infograf768 works4metoo
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC since we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5174.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-26 09:13:03 |
Milestone |
Added: |
I sill see some
These are the
\r\n