? Success

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
23 Nov 2014

There were a bunch of non-printable characters in the SQL files, they are not needed. This PR cleaned them up.

Testing
Install the sample data and check if all the texts are still there.

avatar roland-d roland-d - open - 23 Nov 2014
avatar jissues-bot jissues-bot - change - 23 Nov 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 24 Nov 2014

I sill see some

+(4, 39, 'About your home page', 'about-your-home-page', '<p>Your home page is set to display the four most recent articles from the blog category in a column. Then there are links to the 4 nest oldest articles. You can change those numbers by editing the content options settings in the blog tab in your site administrator. There is a link to your site administrator in the top menu.</p>\r\n<p>If you want to have your blog post broken into two parts, an introduction and then a full length separate page, use the Read More button to insert a break.</p>\r\n', '\r\n<p>On the full page you will see both the introductory content and the rest of the article. You can change the settings to hide the introduction if you want.</p>\r\n<p></p>\r\n<p></p>\r\n<p></p>', 1, 9, '2011-01-03 00:00:01', 713, 'Joomla', '2013-10-13 16:59:32', 713, 0, '0000-00-00 00:00:00', '2012-01-03 00:00:00', '0000-00-00 00:00:00', '{"image_intro":"","float_intro":"","image_intro_alt":"","image_intro_caption":"","image_fulltext":"","float_fulltext":"","image_fulltext_alt":"","image_fulltext_caption":""}', '{"urla":false,"urlatext":"","targeta":"","urlb":false,"urlbtext":"","targetb":"","urlc":false,"urlctext":"","targetc":""}', '{"show_title":"","link_titles":"","show_tags":"","show_intro":"","info_block_position":"0","show_category":"","link_category":"","show_parent_category":"","link_parent_category":"","show_author":"","link_author":"","show_create_date":"","show_modify_date":"","show_publish_date":"","show_item_navigation":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_vote":"","show_hits":"","show_noauth":"","urls_position":"","alternative_readmore":"","article_layout":""}', 7, 1, '', '', 1, 5, '{"robots":"","author":"","rights":"","xreference":""}', 0, '*', ''),
+(5, 40, 'Your Modules', 'your-modules', '<p>Your site has some commonly used modules already preconfigured. These include:</p>\r\n<ul>\r\n<li>Image Module which holds the image beneath the menu. This is a Custom HTML module that you can edit to change the image.</li>\r\n<li>Blog Roll. which lets you link to other blogs. We''ve put in two examples, but you''ll want to change them. When you are logged in, click on blog roll on the top menu to update this.</li>\r\n<li>Most Read Posts which lists articles based on the number of times they have been read.</li>\r\n<li>Older Articles which lists out articles by month.</li>\r\n<li>Syndicate which allows your readers to read your posts in a news reader.</li>\r\n<li>Popular Tags, which will appear if you use tagging on your articles. Just enter a tag in the Tags field when editing.</li>\r\n</ul>\r\n<p>Each of these modules has many options which you can experiment with in the Module Manager in your site Administrator. Moving your mouse over a module and clicking on the edit icon will take you to an edit screen for that module. Always be sure to save and close any module you edit.</p>\r\n<p>Joomla! also includes many other modules you can incorporate in your site. As you develop your site you may want to add more module that you can find at the <a href="http://extensions.joomla.org">Joomla Extensions Directory.</a></p>', '', 1, 9, '2010-12-31 00:00:01', 713, 'Joomla', '2013-10-13 17:59:36', 713, 0, '0000-00-00 00:00:00', '2010-12-31 00:00:01', '0000-00-00 00:00:00', '{"image_intro":"","float_intro":"","image_intro_alt":"","image_intro_caption":"","image_fulltext":"","float_fulltext":"","image_fulltext_alt":"","image_fulltext_caption":""}', '{"urla":false,"urlatext":"","targeta":"","urlb":false,"urlbtext":"","targetb":"","urlc":false,"urlctext":"","targetc":""}', '{"show_title":"","link_titles":"","show_tags":"","show_intro":"","info_block_position":"0","show_category":"","link_category":"","show_parent_category":"","link_parent_category":"","show_author":"","link_author":"","show_create_date":"","show_modify_date":"","show_publish_date":"","show_item_navigation":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_vote":"","show_hits":"","show_noauth":"","urls_position":"","alternative_readmore":"","article_layout":""}', 11, 0, '', '', 1, 4, '{"robots":"","author":"","rights":"","xreference":""}', 0, '*', ''),

These are the \r\n

avatar roland-d
roland-d - comment - 24 Nov 2014

@infograf768 Ah yes, the \r\n that is not something I removed. I removed some funky  characters. I agree the \r\n can be removed as they have no meaning in HTML. I will update the PR.

avatar gwsdesk
gwsdesk - comment - 24 Nov 2014

@roland-d,
Roland please make sure you do not accidentally remove those from the language files ;-) as JM posted yesterday on Chat and I quote "CAREFUL: we use some of these in the ini files. Specially for the mail messages"

avatar infograf768
infograf768 - comment - 24 Nov 2014

As far as I can see here, the patch concerns only the sql

avatar gwsdesk
gwsdesk - comment - 24 Nov 2014

Correct I can see that from the code changes. I promised you yesterday to make a note so I just did :)

avatar roland-d
roland-d - comment - 25 Nov 2014

@infograf768 @gwsdesk Can you please test and let me know if you encounter any issues? Thanks.

avatar gwsdesk
gwsdesk - comment - 25 Nov 2014

@roland-d Patchtester gives me 3 patches 5195/5196/5197 I see from the note that the only one I can test is 5195 since that is MySQL

avatar gwsdesk
gwsdesk - comment - 25 Nov 2014

@roland-d Still having this after applying patch (cleared caching ) See here http://gwsdev5.info/

avatar roland-d
roland-d - comment - 25 Nov 2014

The ID to look for is #5174 that is this patch. The #5195/#5196/#5197 numbers you mentioned are by another user for other fixes.

After applying the patch with the patch tester, you will have to do a new install by removing the configuration.php. Just applying the patch won't change what is already in the database. Did you do a new installation?

avatar gwsdesk
gwsdesk - comment - 25 Nov 2014

@roland-d How can I run a component (com_patchtester) on an existing site with no installation folder a patch when I upload an installation folder which is needed) to run the patch seemingly? What do I miss?

avatar roland-d
roland-d - comment - 25 Nov 2014

Oh you removed the installation folder already? In the alpha you don't have to remove it, the check for the installation folder is still disabled. What you can do, is copy the installation folder from the zipped file into your existing installation excluding the installation/sql/ folder and then start the installation. If you prefer a complete zipfile, let me know and I can create one.

avatar infograf768
infograf768 - comment - 25 Nov 2014

OK for me in sql.
May need to correct the absence of space after period in sample blog
"This is a contact form which you can edit in the contact manager.Put your address or other information here. etc.

avatar roland-d
roland-d - comment - 25 Nov 2014

Thanks @infograf768 Added the missing space.

avatar gwsdesk
gwsdesk - comment - 25 Nov 2014

@roland-d , @infograf768 works4metoo

avatar roland-d roland-d - alter_testresult - 25 Nov 2014 - infograf768: Tested successfully
avatar roland-d roland-d - alter_testresult - 25 Nov 2014 - gwsdesk: Tested successfully
avatar roland-d roland-d - change - 25 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 25 Nov 2014

Moving to RTC since we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5174.

avatar infograf768 infograf768 - reference | 3242f76 - 26 Nov 14
avatar infograf768 infograf768 - merge - 26 Nov 2014
avatar infograf768 infograf768 - close - 26 Nov 2014
avatar infograf768 infograf768 - close - 26 Nov 2014
avatar infograf768 infograf768 - change - 26 Nov 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-11-26 09:13:03
avatar infograf768 infograf768 - change - 26 Nov 2014
Milestone Added:
avatar alikon alikon - reference | 09c6780 - 30 Nov 14
avatar alikon alikon - reference | 33f11c1 - 30 Nov 14
avatar alikon alikon - reference | 2e185f1 - 30 Nov 14
avatar roland-d roland-d - head_ref_deleted - 6 May 2015

Add a Comment

Login with GitHub to post a comment