PR-staging

Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
14 Nov 2014

Smart search spoils every page that has it!

Inline scripts are bad.
This PR removes the inline script for module and component finder (front end ONLY).

Test

** Make sure you have some data and you have indexed stuff in finder **
1. Got to admin -> System -> Global configuration and click on the left panel at Smart Search
2. Disable everything
3. Apply this with Patchtester
4. Go to front end at the page you have mod_finder published and make a search
5. Got to admin -> System -> Global configuration and click on the left panel at Smart Search and start enabling options
For each one you enabling go to front end make a search

Please also watch your browser console log for script errors

The script should be on the page’s <head> like this:
screen shot 2014-11-14 at 11 05 47

avatar dgt41 dgt41 - open - 14 Nov 2014
avatar jissues-bot jissues-bot - change - 14 Nov 2014
Labels Added: PR-staging
avatar dgt41
dgt41 - comment - 14 Nov 2014

@Bakual Thomas a quick question: what is the procedure for inclusion of an external library to the project? I found this which can replace the finder’s respective script, and thus, remove the mootools dependency from finder. (for the SITE part!)

avatar brianteeman brianteeman - change - 14 Nov 2014
Category JavaScript
avatar dgt41 dgt41 - change - 17 Nov 2014
Title
Remove the inline script from mod_finder
Introduce jquery formvalidator for mod_finder
avatar dgt41 dgt41 - change - 17 Nov 2014
Title
Introduce jquery formvalidator for mod_finder
Introduce jquery formvalidator for mod_finder ::frontend
avatar dgt41
dgt41 - comment - 17 Nov 2014

Closing this one, we have a new PR: #5128 that converts also mootools auto suggest script

avatar dgt41 dgt41 - close - 17 Nov 2014
avatar dgt41 dgt41 - close - 17 Nov 2014
avatar dgt41 dgt41 - change - 17 Nov 2014
Title
Remove the inline script from mod_finder
Introduce jquery formvalidator for mod_finder ::frontend
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-17 10:54:51
avatar dgt41 dgt41 - head_ref_deleted - 18 Nov 2014

Add a Comment

Login with GitHub to post a comment