Feeling Lucky
?
[#5084] - Options passed to JHtmlBootstrap::modal() have no effect
- Closed
- 11 Nov 2014
- Medium
- Build: master
- # 5084
Referenced as
Related to:
# 5087
Try to pass any native bootstrap modal option as a parameter (e.g. "backdrop" => false), and you will see that it has no effect. This is normally not done by directly calling JHtmlBootstrap::modal() but JHtmlBootstrap::renderModal()
The JS generated to control these options is ineffective...
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
4.00
jissues-bot
- | Labels |
Added:
?
|
||
smanzi
- comment
- 11 Nov 2014
I have a working PR ready: will publish tomorrow...
Bakual
- comment
- 11 Nov 2014
Closing this issue in favor of PR
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-11 21:53:52 |
My understanding is that the generated JS:
is used to activate a modal and pass it some options, and not to set the options.
If this the case, we should parse the options in JHtmlBootstrap::renderModal() and add them as data- attributes to the .modal <div>
If this is the case modal() will become useless and should be substituted with an empty function for BC.