Feeling Lucky
?
[#5083] - Who's online module shows multiple entries for a user name in release 3
- Closed
- 15 Nov 2014
- Medium
- Build: master
- # 5083
Steps to reproduce the issue
Create multiple sessions for the same username
Expected result
A single entry for a username in the list of who is online
Actual result
Multiple occurrence of a username in the list
System information (as much as possible)
This didn't happen in release 2.5 but does in release 3.
I think it is caused by the SQL statement in helper.php
In 2.5 there is a group by username
In 3 the group by is username date and time meaning uniqueness is at a session not username level
Additional comments
This could be viewed as a feature rather than a bug - however it is causing a lot of confusion to users when they see there name several times. I have had questions like 'has my account been hacked'
zero-24
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-15 12:47:25 |
| Labels |
Added:
?
|
||
The group clause is still there. See https://github.com/joomla/joomla-cms/blob/staging/modules/mod_whosonline/helper.php#L84
However it's a bit different due to having to support multiple databases. And it basically shows that the query is wrong as it is.
If you want to group by username (or id), you can't select "a.time" since that one is different for each row.
So we would have to remove
a.timefrom the select and the group and it should work.Can you maybe do a pull request for that? You can have a look at http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests to see how you can do it.