Feeling Lucky
?
[#5068] - Reveal sidebar for tablets & mobiles
- Closed
- 9 Nov 2014
- Medium
- Build: staging
- # 5068
- Diff
- dgt41:sidebar
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This solves the issue #5066
Testing
Apply patch
Navigate to admin and some area with sidebar e.g. Menus
Resize the window
From 728px and bellow should reveal automatically the sidebar
jissues-bot
- | Labels |
Added:
?
|
||
dgt41
- comment
- 9 Nov 2014
@phproberto I totally agree with you! This was a quick workaround. I think all this has to be done using some ready available code, there are many people that suggested a few nice implementations…
Also this is not DRY at all
dgt41
- comment
- 9 Nov 2014
OK I give up, this doesn’t seem to respect the $visible condition
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-09 10:18:56 |
A lot of the logic that is being applied with JS should be switched to CSS and use media queries in each template to customise things like this.