Feeling Lucky
?
[#5067] - Fixing JGithub repository contents api
- Fixed in Code Base
- 22 Nov 2014
- Medium
- Build: staging
- # 5067
- Diff
- Skullbock:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fix is already applied in the Framework Package.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
zero-24
- comment
- 9 Nov 2014
@Skullbock any kinde of testing needed?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5067.
zero-24
- comment
- 9 Nov 2014
@Skullbock can you fix the unit tests?
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 10 Nov 2014
moving RTC since travis is happy now and this is a backport from the framework. Thanks @Skullbock
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5067.
Skullbock
- comment
- 10 Nov 2014
No problem. Working during jwc14 on joomla seemed like a good "fit" 
mbabker
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-22 02:46:05 |
| Status | Closed | ⇒ | Fixed in Code Base |
Looks good.
BTW: This has already been fixed in the "proper" API implementation here:
https://github.com/joomla-framework/github-api/blob/master/src/Package/Repositories/Contents.php#L71-75