@test success

@test success!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5058.

@smanzi @anibalsanchez Thank you very much for testing all these PRs. I owe you some beers ????

@dgt41 @anibalsanchez That would be great!

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5058.

I think we need at least an extra test to validate that my latest changes to the group management work.

How to test it

• When trying to delete a group with users inside you should see an alert box asking you confirmation
• When trying to delete a group with no users you should be able to delete it without confirmation

test
works good for me

@test OK

• Group deletion without users, Ok
• Group deletion with users, standard alert, confirmation Yes, OK (group deleted)
• Group deletion with users, standard alert, confirmation No, OK (group not deleted)

@Fedik @anibalsanchez Thanks, your help is really appreciated. Can I ask you to check also, if you have spare time,
#5047 (administrator/components/com_menus/views/item/tmpl/edit_modules.php AND administrator/components/com_menus/views/menutypes/tmpl/default.php)
#5046 (administrator/components/com_languages/views/override/tmpl/edit.php)

@test success (all groups deletion conditions too...)

Just be a little bit picky, I hate alert messages (the "standard" ones), also because they can be switched off at the browser level. I think we should design our own modal-based alert/confirmation message...

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

@test success for this PR (created new article in front-end, no prob!)
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

sorry, misplaced comment above!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5058.

I'm confused here. Didn't we get rid of that inline scripts? I submitted a PR dgt41#10 and @dgt41 merged it but I cannot see it?

@phproberto: @dgt41 merged your PR 9 days ago, but I don't see signs of commits here at the same time...

Wrong: there is the commit. It is bb11e3a

... or not ...

No. Inline scripts are back and my commit is gone.

My branch is still online in case you need it @dgt41 https://github.com/phproberto/joomla-cms/commits/dgt41-5058-2

It seems good Dimitris gone ....

Still here try to figure out what happen…

ah, OK, sorry!!!

The strange thing is that in commit dgt41@9999882 the code is there and disappears out of the blue!
Can we test it one more time?

@smanzi @phproberto here is ok!

here too! e.g.: the patch downloaded by com_patchtester has at line 26-31 of administrator/components/com_users/views/groups/tmpl/default.php:

$script = '
    Joomla.submitbutton = function(task) {
        if (task == "groups.delete")
        {
            var f = document.adminForm;
            var cb="";';

Yeah I pushed the code again…

... but I didn't reapply the patch: this is from my original patch that applied when started testing tonight...

do you want me to re-apply & re-test this?

if you can but give me a minute

no prob, give me the "go"...

go!

Is looking good here!

Yes, now code different and anyway @test success!

Thanks. All seems ok now. We need to wait to travis so I'll go to sleep.

You did an awesome work tonight. Thanks!!

again @test success!

Good night, everybody!

Its time ????

test
works good for me

@test OK

• New user,mandatory fields
• User Modification, mandatory fields
• Group deletion without users, Ok
• Group deletion with users, standard alert, confirmation Yes, OK (group deleted)
• Group deletion with users, standard alert, confirmation No, OK (group not deleted)

Merged into staging. Thanks!