? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
8 Nov 2014

Executive summary

This PR converts the form validation on com_redirect to use plain jquery (no mootools call on every form

avatar dgt41 dgt41 - open - 8 Nov 2014
avatar jissues-bot jissues-bot - change - 8 Nov 2014
The description was changed
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2014
Category JavaScript
avatar smanzi
smanzi - comment - 11 Nov 2014

@test success

avatar anibalsanchez
anibalsanchez - comment - 13 Nov 2014

I have applied the patch on 3.3.6, but I'm getting:

An error has occurred. 500 Layout default_batch not found

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

avatar smanzi
smanzi - comment - 13 Nov 2014

@anibalsanchez That's strange... I've tested it on 3.3.6 too: no problem. Do you use com_patchtester for applying the the PRs?

avatar dgt41
dgt41 - comment - 13 Nov 2014

@anibalsanchez Checking the repo 3.3.6 I see that this file doesn’t exist there. It must have been added later on

avatar smanzi
smanzi - comment - 13 Nov 2014

Guys, I just tested it again, just to be sure, and... no problem! What's going on here??

avatar anibalsanchez
anibalsanchez - comment - 13 Nov 2014

Yes, patchtester applies it Ok... weird ... how a fresh install have become corrupted in com_redirect.

I have applied #4888 and #5052 in other site, it works OK. @test success!

avatar smanzi
smanzi - comment - 13 Nov 2014

@anibalsanchez can it be that you have other unrelated PRs applied? Unhappily in com_patchtester we don't have a filter to see which one are currently applied and we must scroll the whole list...

avatar dgt41
dgt41 - comment - 13 Nov 2014

@smanzi I already requested one more view in com_patchtester, take a look here ianmacl/patchtester#9

avatar anibalsanchez
anibalsanchez - comment - 13 Nov 2014

It is a clean installation for these tests ... anyway I'm re-installing and keeping an eye on patching consistency.

avatar smanzi
smanzi - comment - 13 Nov 2014

@dgt41 Ooops... I just did the same request here: joomla-extensions/patchtester#54

avatar smanzi
smanzi - comment - 13 Nov 2014

@dgt41 Actually not the same request. I think you made yours in the wrong repo...

avatar dgt41
dgt41 - comment - 19 Nov 2014

@roland-d this, as well, got 2 good tests (you have to go through the comments)

avatar roland-d roland-d - alter_testresult - 19 Nov 2014 - smanzi: Tested successfully
avatar roland-d roland-d - alter_testresult - 19 Nov 2014 - anibalsanchez: Tested successfully
avatar roland-d
roland-d - comment - 19 Nov 2014

@dgt41 Thanks for the info. That is why we are trying to get people to use the Test results module on every issue, so we can easily see how many tests it has. Reading long commments isn't always as clear ;)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

avatar roland-d roland-d - change - 19 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 19 Nov 2014

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.

avatar dgt41
dgt41 - comment - 19 Nov 2014

@roland-d I can see all the hard word needed in the current workflow, that’s why I proposed this but it was turned down...

avatar roland-d
roland-d - comment - 20 Nov 2014

@dgt41 Yeah the current workflow isn't ideal. Thanks for the link, I will comment there.

avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar smanzi
smanzi - comment - 30 Nov 2014

@dgt41 there are problems with this...
Creating a new redirection I get in console:

TypeError: document.formvalidator is null index.php:30
Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2
TypeError: b is null core.js:1

And I cannot save the redirection...

avatar smanzi
smanzi - comment - 30 Nov 2014

Also, tooltips not correctly rendered...

avatar smanzi smanzi - test_item - 30 Nov 2014 - Tested unsuccessfully
1ca45da 30 Nov 2014 avatar dgt41 typo
avatar dgt41
dgt41 - comment - 30 Nov 2014

Fixed, for tooltips there is #5137

avatar smanzi smanzi - test_item - 30 Nov 2014 - Tested successfully
avatar smanzi
smanzi - comment - 30 Nov 2014

Confirmed!
Tooltips malfunction was related, but it is now OK!

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

avatar phproberto phproberto - change - 30 Nov 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-11-30 02:13:00
avatar phproberto phproberto - close - 30 Nov 2014
avatar zero-24 zero-24 - close - 30 Nov 2014
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment