User tests: Successful: Unsuccessful:
This PR converts the form validation on com_redirect to use plain jquery (no mootools call on every form
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
I have applied the patch on 3.3.6, but I'm getting:
An error has occurred. 500 Layout default_batch not found
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.
@anibalsanchez That's strange... I've tested it on 3.3.6 too: no problem. Do you use com_patchtester for applying the the PRs?
@anibalsanchez Checking the repo 3.3.6 I see that this file doesn’t exist there. It must have been added later on
Guys, I just tested it again, just to be sure, and... no problem! What's going on here??
@anibalsanchez can it be that you have other unrelated PRs applied? Unhappily in com_patchtester we don't have a filter to see which one are currently applied and we must scroll the whole list...
@smanzi I already requested one more view in com_patchtester, take a look here ianmacl/patchtester#9
It is a clean installation for these tests ... anyway I'm re-installing and keeping an eye on patching consistency.
@dgt41 Ooops... I just did the same request here: joomla-extensions/patchtester#54
@dgt41 Thanks for the info. That is why we are trying to get people to use the Test results module on every issue, so we can easily see how many tests it has. Reading long commments isn't always as clear ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5052.
Labels |
Added:
?
|
@dgt41 there are problems with this...
Creating a new redirection I get in console:
TypeError: document.formvalidator is null index.php:30
Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2
TypeError: b is null core.js:1
And I cannot save the redirection...
Also, tooltips not correctly rendered...
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-30 02:13:00 |
Labels |
Removed:
?
|
@test success