[#5016] - [#29248] FrontEnd - Disabling Show Navigation setting does not affect article
- Closed
- 14 Mar 2015
- Medium
- Build: staging
- # 5016
- Diff
- zero-24:patch-9
- Foreign ID 29248
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Tracker
Code by Karthikeyan S @skarthik2020
How to redpoduce
Log into your Joomla 3.0 admin dashboard In the top menu, click Content and then click Article Manager In the list of articles on the page, click the article title that you want to toggle the Show Navigation setting for You will see several tabs above the article, click the Article Options tab Find the setting labeled Show Navigation. Set it to "Hide", and then click "Save" in the top left
When I set the "Show Navigation" setting for a specific article to "Hide", I still see the navigational buttons on the page.
Votes
jissues-bot
- | Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Front End Plugins |
tested. works fine
| Status | Pending | ⇒ | Ready to Commit |
Thanks @losedk moving to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
After reproducing the error, I left the options set to "show navigation: hide". I applied the patch, and navigated to the article: no change, navigation still set up.
With the patch still applied, I changed the option to "show navigation: use global" and received this error on the article.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
Good catch but unfortunately wrong fix 
The issue comes from the article view. It passes $this->params as attribute to the plugin event, but it should pass $item->params instead.
The difference between the two is that the first contains the menu params and the latter contains the merged params from menu and article.
So it likely is wrong for other plugins as well.
@zero-24 Can you change your PR?
| Status | Ready to Commit | ⇒ | Pending |
Reset tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
Code looks fine except what I noted inline.
Hi all,
how can I apply the patch ?
Thx in advance
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
@samanoudi You can download the patchtester (https://github.com/joomla-extensions/patchtester) - It's explained here: https://www.youtube.com/watch?v=4OWgusZgIfk
christianhent
- 
Tested. Works fine.
tested- it works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
test confirmed. works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
tested - ok
tested. works ok.
tested - ok
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
Multiple good tests - thanks for testing - setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Merged to staging
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-14 15:31:49 |
I just updated my site to v3.4.1 and articles aren't shown anymore. Reverting this commit brings them back. Another user reported me the same issue so I think something is wrong in this patch.
Forget it. It was a third part plugin replacing parameters...
| Labels |
Removed:
?
|
||
@test successful as the code is by Karthikeyan S @skarthik2020 see JC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5016.