? ?

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
7 Nov 2014

Issue

There is no simple way for a user to see if an installed extension will also be available after the upgrade to Joomla! 3.3.

Proposal

This PR will collect the compatibility information from the updateserver stream. It will show them as a tooltip in the Extension Manager

Technical Details

I admit it's a bit a hack, but I had some fun digging through our updater and learned quite a bit :smile:
What this does is:

  • During searching for available updates, this PR will store the information from the targetplatform attribute in the updateserver stream into an array.
  • At the end of the update searching process, it will take the values for the currently installed version and for the latest available version and stores them into the currently not used system_data column in the #__extensions table. It does this as a JSON string. This will create an additional query for extension which have an updateserver.
  • In the Extension Manager -> Manager view, it will now show a tooltip icon behind the version if compatibility information is available. The tooltip will show the information for the current and the latest available version

Testing

Test with 3rd party extensions. Those using an updateserver should show the information after you have searched for available updates (doesn't matter if there are updates or not).

Feedback welcome

avatar Bakual Bakual - open - 7 Nov 2014
avatar jissues-bot jissues-bot - change - 7 Nov 2014
Labels Added: ?
avatar roland-d
roland-d - comment - 8 Nov 2014

@Bakual Great proposal. One thing I think should be different is that the information that it is J3 ready should not be an i icon as tooltip but maybe use the Joomla 3.x tag like we use at the JED and add the tooltip to that. What do you say?

avatar Bakual
Bakual - comment - 9 Nov 2014

The current icon is just the default icon from Joomla. So we sure can change this.

However using a "Joomla 3.x" icon isn't appropriate and could be misleading: The code currently doesn't check if the extension is compatible with J3 or not, it just compiles the information and shows it in the tooltip. So if we show a J3 icon but the extension isn't compatible it would give a wrong sign to the user.

avatar jsubri
jsubri - comment - 9 Nov 2014

tested /administrator/index.php?option=com_installer&view=manage on 2.5.17 multilingual, with old PHP 5.2 work as expected, tool tips in English
5015

avatar roland-d
roland-d - comment - 14 Nov 2014

@Bakual Fair point. Good to go for me. Test is good.

avatar roland-d roland-d - test_item - 14 Nov 2014 - Tested successfully
avatar roland-d roland-d - alter_testresult - 14 Nov 2014 - jsubri: Tested successfully
avatar roland-d roland-d - change - 14 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 14 Nov 2014

Moving to RTC as we have 2 succesful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5015.

avatar infograf768
infograf768 - comment - 15 Nov 2014

Do I understand well that, although the infos will show in the Extension Manager->manage, there is no other way for the site administrator to be aware of this?

avatar roland-d
roland-d - comment - 15 Nov 2014

@infograf768 Correct, this PR only adds the information there.

avatar infograf768
infograf768 - comment - 15 Nov 2014

Hmm...
What do you think folks about setting a fixed message in CPanel with something like:
"When you decide to update your site to version 3.x.x, make sure to check the compatibility of your extensions at [link]"

The message could be displayed in bold/red on top of the modules.

avatar infograf768
infograf768 - comment - 15 Nov 2014

in both templates Hathor and bluestork

avatar infograf768
infograf768 - comment - 15 Nov 2014

For example:
screen shot 2014-11-15 at 12 02 57

avatar brianteeman
brianteeman - comment - 15 Nov 2014

@infograf768 if you're going to have the message then wouldn't it be better to place it on the com_joomlaupdate screen ?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5015.

avatar infograf768
infograf768 - comment - 15 Nov 2014

The user will not go to the joomlaupdate screen except if he changes from LTS to STS I guess.
Also he could decide to update via the Extensions Manager->install.

I thought more interesting to put it in the CPanel to let users know for sure and also to promote upgrade to version 3... :)

avatar brianteeman
brianteeman - comment - 15 Nov 2014

The issue with that is they may be using a custom admin template
On 15 Nov 2014 11:20, "infograf768" notifications@github.com wrote:

The user will not go to the joomlaupdate screen except if he changes from
LTS to STS I guess.
Also he could decide to update via the Extensions Manager->install.

I thought more interesting to pit it in the CPanel to let users know for
sure and also to promote upgrade to version 3... :)


Reply to this email directly or view it on GitHub
#5015 (comment).

avatar Bakual
Bakual - comment - 15 Nov 2014

I think it would make most sense to have it on the EOL notification plugin (#5063) or as part of the doc page linked from that plugin.

avatar roland-d
roland-d - comment - 15 Nov 2014

Sounds good to me to make it part of the EOL notification plugin. One place to rule them all :)

avatar bayareajenn
bayareajenn - comment - 18 Nov 2014

@Bakual i can add this functionality to the documentation that is linked from the EOL notification plugin (#5063). since addressing each and every extension is given in the planning and step by step, i can direct people to this functionality in the manage tab once i totally understand what it does and doesn't do.

question (and i'm sorry i haven't tested it yet): does this only give the tooltip if the extension grabs update info from the extension manager -> update tab? said another way, if the extension doesn't update via the one-click updater, the site admin will need to go physically look at the extension (via the JED or the dev website) and whether it is compatible with Joomla! 3, correct?

and then, just because the extension is compatible with 3 doesn't necessarily mean that it doesn't need to be uninstalled in 2.5.x and then reinstalled with the 3.x version. what you've done up here doesn't substitute for still checking each extension to verify the mini-migration path, correct?

thanks very much!! quite nice. :)
jenn

avatar Bakual
Bakual - comment - 18 Nov 2014

does this only give the tooltip if the extension grabs update info from the extension manager -> update tab? said another way, if the extension doesn't update via the one-click updater, the site admin will need to go physically look at the extension (via the JED or the dev website) and whether it is compatible with Joomla! 3, correct?

Exactly. It only works if the extension uses the Joomla one-click updater.

and then, just because the extension is compatible with 3 doesn't necessarily mean that it doesn't need to be uninstalled in 2.5.x and then reinstalled with the 3.x version. what you've done up here doesn't substitute for still checking each extension to verify the mini-migration path, correct?

It will show the compatibility for the currently installed version and for the latest available version.
The tooltip will look like this:

Installed version (4.5.0) works with Joomla! versions 2.5, 3,3.
Latest available version (5.3.0) works with Joomla! versions 3,2, 3,3."

I'd say if the currently installed version is compatible with J3, then you don't have to uninstall it. For most extensions it should work. Except maybe for extensions which have two different codebases for the same version, one for 2.5 and one for 3. I know there are a few developers which took that approach.
I wouldn't uninstall the incompatible extensions however. I would just deactivate them. Uninstalling will also remove the data, at least if the extension is properly written.

avatar bayareajenn
bayareajenn - comment - 18 Nov 2014

thank you @Bakual your explanation is helpful. now i can word things properly when i add it to the docs.

yes, the great debate to deactivate or uninstall. i go with it depends. a lot of us uninstall everything we can to minimize the white screen of death. and let's face it, a content plugin is no big deal to uninstall in 2.5 and reinstall in 3.x. but that's a different topic.

when it comes on where to place this in case of a different admin template in use, i agree with @brianteeman to have it on the update page if it needs to be somewhere else besides in the documentation linked from the EOL plugin.

that being said, we're still in discussion on the same issue in the update working group as to the problem of if the site is using a different admin template and then the EOL plugin wouldn't appear either. good to see this discussed. i guess we better have a quick link for EOL as well as the notification across the top to make sure they get to where they need to go to upgrade properly.

so this notification for versions in Extension Manager -> Manage is going to be in 2.5.28 yes?

thanks again, well done.

avatar Bakual
Bakual - comment - 18 Nov 2014

so this notification for versions in Extension Manager -> Manage is going to be in 2.5.28 yes?

I'd say yes. Nobody complained so far :smile:

About the EOL plugin. are there really any admin template which doesn't show regular messages (like "article saved"). That would be quite a stupid template imho. I'd say it should work always.

avatar roland-d
roland-d - comment - 18 Nov 2014

:+1: for including it in 2.5.28. Good job.

avatar bayareajenn
bayareajenn - comment - 18 Nov 2014

About the EOL plugin. are there really any admin template which doesn't show regular messages (like "article saved"). That would be quite a stupid template imho. I'd say it should work always.

agreed and we were just talking about that in the group so no worries. i'll change the documentation once 2.5.28 is released to include this functionality and how people can use it.

avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 1 Dec 2014

Merged into 2.5.x.

avatar Bakual Bakual - close - 1 Dec 2014
avatar zero-24 zero-24 - close - 1 Dec 2014
avatar Bakual Bakual - change - 1 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-01 21:52:00
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment