? Success

User tests: Successful: Unsuccessful:

avatar asika32764
asika32764
6 Nov 2014

Throw some exceptions if developer did not complete the contentType information.

Otherwise it is only return get property from non object and hard to debug.

avatar asika32764 asika32764 - open - 6 Nov 2014
avatar jissues-bot jissues-bot - change - 6 Nov 2014
Labels Added: ?
avatar asika32764 asika32764 - change - 6 Nov 2014
The description was changed
avatar zero-24
zero-24 - comment - 9 Nov 2014

@asika32764 looks ok any kind of testing required?

BTW: I'm not 100% sure but are you expect namespacing?

throw new \LogicException('Please add a row to content_type');

Also a thing that need to decide e.g. by @infograf768 should we use JText / Language strings here?

avatar Hackwar
Hackwar - comment - 27 Dec 2014

I also give this a go, but share the concerns by @zero-24

avatar wilsonge
wilsonge - comment - 27 Dec 2014

JText isn't compulsory I think we've decided as long as the front facing user won't see them. The namespacing thing i can solve on merging.

avatar infograf768
infograf768 - comment - 28 Dec 2014

Indeed, any message that will not be displayed to the end user does not 'really' need to be translated in Joomla for 2015.

PHP coders are supposed to practice English or change hobby/profession... at least while English is still the lingua franca ( http://en.wikipedia.org/wiki/Lingua_franca ) used in the World for PHP coding.
Taking into account the much larger increase in population in parts of the World where English is not hegemonic, this could change faster than some think...

See: http://en.wikipedia.org/wiki/List_of_languages_by_number_of_native_speakers

avatar roland-d
roland-d - comment - 4 Sep 2015

Hello @asika32764

Thank you for your contribution.

The last comment here was on [date]. So the question is, Is this issue/pull request still valid?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5003.

avatar asika32764
asika32764 - comment - 4 Sep 2015

I think this is still valid. this PR is a little improvement to make developer more easier to use UCM, not for end user.

But I'm not sure is there any concerns merging this PR.

avatar roland-d
roland-d - comment - 5 Sep 2015

@asika32764 UCM is barely used and from what I see, UCM is not going to be further used by the core and will most likely be removed altogether in the future. Given that, I don't think this PR adds much to the core and shouldn't be merged in my opinion. If that is OK with you, I will close the issue.

Thank you for your contributions as always.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5003.

avatar asika32764
asika32764 - comment - 5 Sep 2015

Yes, just close it.

avatar roland-d
roland-d - comment - 5 Sep 2015

Closing as discussed.

avatar roland-d roland-d - change - 5 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-05 16:05:22
Closed_By roland-d
avatar roland-d roland-d - close - 5 Sep 2015

Add a Comment

Login with GitHub to post a comment