[#5002] - [fix] Multilanguage: Checking proper default menu item in mod_menu
- Closed
- 6 Nov 2014
- Medium
- Build: staging
- # 5002
- Diff
- infograf768:multilang_modmenu
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Same issue as in #4994 which was merged and solved the pathway if in the _menu table the row mainmenu with Home set to Language All, i.e. *, is deleted.
See specifically the comment #4994 (comment)
To test use a multilang site, delete the said menu item.
Create a tag and apply to some articles. Display these articles once at least in frontend.
Create a Popular Tags module and display in frontend.
As $menu->getDefault() does not exist, you will get many notices including
Notice: Trying to get property of non-object in ROOT\modules\mod_menu\helper.php on line 40
Patch and retest
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Multilanguage |
Although unrelated to this PR, please explain further the issue with archived article. What do you mean by
select the article from the "archived module"
Here, even if I create an archived articles module set to ALL languages, it will display a month link if any archived article is set to the displayed language. Clicking on the link will display the article OK.
What does not work is the association between 2 archived articles. In that case, one is redirected to the home page for the language chosen in the switcher
Oops, did not test when the row is deleted.
Will do now
I confirm the 404 when clicking on the flag for the language concerned when the archived article is displayed.
Instead of getting for example
/index.php/fr/home-fr-fr/2014?view=archive&month=11 (the link in the archived module)
or
/index.php/fr/
we get
/index.php/fr/home-fr-fr/2014
As my test was wrong in #5002 (comment)
I confirm we have the same issue when the row is not deleted
Thanks for testing. Merging.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-06 16:16:33 |
@test Success!
Remark: I found another problem that is related to this test case - the deleted row in the _menu table:
You should experience an 404 error.