? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
2 Nov 2014

Executive Summary

The multilingual installer will not install sample data in postgres. This fixes it.

More detail

Various not null fields are not passed into the data being binded in the multilingual installer. To avoid this I've used the bind method to ensure the rules are created properly and added in the missing fields

Testing instructions

In mysql ensure that the multilingual installer continues to work as expected when installing data (make sure you enable all 3 options for data to install to test all options)

In postgres you can try running the multilingual installer first to prove there are errors. Note the languages will install thanks to previous PR's however the data will not be added correctly. Note you MUST test this with the staging branch. Apply the patch and all the data should be created properly (make sure you enable all 3 options for data to install to test all options). This includes the language switcher module, content, category and menu items.

avatar wilsonge wilsonge - open - 2 Nov 2014
avatar jissues-bot jissues-bot - change - 2 Nov 2014
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Nov 2014
Category Postgresql
avatar wilsonge wilsonge - change - 2 Nov 2014
The description was changed
avatar infograf768
infograf768 - comment - 3 Nov 2014

@test
Multilanguage installation went fine on mysqli

avatar waader
waader - comment - 3 Nov 2014

@test

  • mysqli installation went fine, but when going in the category manager there is a warning that doesn´t appear when installing without the patch:
    Warning: str_repeat(): Second argument has to be greater than or equal to 0 in 192.168.1.17\joomla33_test\administrator\components\com_categories\views\categories\tmpl\default.php on line 167

  • postgres installation went fine and as you described many core components are broken as long as the language filter is published (same warning as with mysqli)

avatar wilsonge wilsonge - change - 3 Nov 2014
The description was changed
avatar wilsonge wilsonge - change - 4 Nov 2014
The description was changed
avatar wilsonge
wilsonge - comment - 4 Nov 2014

@waader @infograf768 Can you retest please? Should have fixed that issue with categories

avatar infograf768
infograf768 - comment - 4 Nov 2014

Will test tomorrow

avatar waader
waader - comment - 4 Nov 2014

With Postgres I get the following error in launching the category manager:

Error

Database query failed (error # %s): %s SQL=SELECT a.id, a.title, a.alias, a.note, a.published, a.access, a.checked_out, a.checked_out_time, a.created_user_id, a.path, a.parent_id, a.level, a.lft, a.rgt, a.language,l.title AS language_title,uc.name AS editor,ag.title AS access_level,ua.name AS author_name,COUNT(asso2.id)>1 as association FROM couj5_categories AS a LEFT JOIN "couj5_languages" AS l ON l.lang_code = a.language LEFT JOIN couj5_users AS uc ON uc.id=a.checked_out LEFT JOIN couj5_viewlevels AS ag ON ag.id = a.access LEFT JOIN couj5_users AS ua ON ua.id = a.created_user_id LEFT JOIN couj5_associations AS asso ON asso.id = a.id AND asso.context='com_categories.item' LEFT JOIN couj5_associations AS asso2 ON asso2.key = asso.key WHERE a.extension = 'com_content' AND (a.published IN (0, 1)) GROUP BY a.id ORDER BY a.lft asc Database query failed (error # %s): %s SQL=SELECT a.id, a.title, a.alias, a.note, a.published, a.access, a.checked_out, a.checked_out_time, a.created_user_id, a.path, a.parent_id, a.level, a.lft, a.rgt, a.language,l.title AS language_title,uc.name AS editor,ag.title AS access_level,ua.name AS author_name,COUNT(asso2.id)>1 as association FROM couj5_categories AS a LEFT JOIN "couj5_languages" AS l ON l.lang_code = a.language LEFT JOIN couj5_users AS uc ON uc.id=a.checked_out LEFT JOIN couj5_viewlevels AS ag ON ag.id = a.access LEFT JOIN couj5_users AS ua ON ua.id = a.created_user_id LEFT JOIN couj5_associations AS asso ON asso.id = a.id AND asso.context='com_categories.item' LEFT JOIN couj5_associations AS asso2 ON asso2.key = asso.key WHERE a.extension = 'com_content' AND (a.published IN (0, 1)) GROUP BY a.id ORDER BY a.lft asc LIMIT 20 Database query failed (error # %s): %s SQL=SELECT a.id, a.title, a.alias, a.note, a.published, a.access, a.checked_out, a.checked_out_time, a.created_user_id, a.path, a.parent_id, a.level, a.lft, a.rgt, a.language,l.title AS language_title,uc.name AS editor,ag.title AS access_level,ua.name AS author_name,COUNT(asso2.id)>1 as association FROM couj5_categories AS a LEFT JOIN "couj5_languages" AS l ON l.lang_code = a.language LEFT JOIN couj5_users AS uc ON uc.id=a.checked_out LEFT JOIN couj5_viewlevels AS ag ON ag.id = a.access LEFT JOIN couj5_users AS ua ON ua.id = a.created_user_id LEFT JOIN couj5_associations AS asso ON asso.id = a.id AND asso.context='com_categories.item' LEFT JOIN couj5_associations AS asso2 ON asso2.key = asso.key WHERE a.extension = 'com_content' AND (a.published IN (0, 1)) GROUP BY a.id ORDER BY a.lft asc LIMIT 20

avatar wilsonge
wilsonge - comment - 4 Nov 2014

@waader You'll need to apply #4972 to fix it :)

avatar waader
waader - comment - 4 Nov 2014

Sorry, you are right!

@test Success! (Postgres & Mysqli)

avatar infograf768
infograf768 - comment - 7 Nov 2014

OK in mysqli. Merging. Thanks.

avatar infograf768 infograf768 - change - 7 Nov 2014
Milestone Added:
avatar infograf768 infograf768 - close - 7 Nov 2014
avatar infograf768 infograf768 - reference | 2b7d3ab - 7 Nov 14
avatar infograf768 infograf768 - merge - 7 Nov 2014
avatar infograf768 infograf768 - close - 7 Nov 2014
avatar infograf768 infograf768 - change - 7 Nov 2014
The description was changed
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-07 11:16:23
avatar wilsonge wilsonge - head_ref_deleted - 7 Nov 2014

Add a Comment

Login with GitHub to post a comment