? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
1 Nov 2014

Fixed "TypeError: $(...).ready is not a function" when loading a Google Map with jQuery

To test:

jimport('jquery.framework');
$options = new JRegistry;
$options->set('autoload', 'jquery');

$google = new JGoogle($options);
$map = $google->embed('Maps');

$map->setCenter(array(48.1415102, 11.548463), 'Test');

$map->echoHeader();
$map->echoBody();

Before patch: you get the javascript error in the Console
After: map should be shown

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
1.00

avatar bembelimen bembelimen - open - 1 Nov 2014
avatar jissues-bot jissues-bot - change - 1 Nov 2014
Labels Added: ?
avatar illovo
illovo - comment - 2 Nov 2014

@test
works as described

Add

#map_canvas{ width:100%; height:100%; }

inside HEAD during test!

avatar infograf768
infograf768 - comment - 2 Nov 2014

Travis does not like it:

1) JGoogleEmbedMapsTest::testGetHeader

Failed asserting that '' contains "$(document).ready(".

avatar chmst chmst - test_item - 2 Nov 2014 - Tested successfully
avatar chmst
chmst - comment - 2 Nov 2014

Screens made before and after the patch, Joomla! Version 3.3.7_dev
screen shot 2014-11-02 at 06 12 49screen shot 2014-11-02 at 06 12 49

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4968.

avatar bembelimen
bembelimen - comment - 3 Nov 2014

@infograf768 I updated the test case, Travis should work now.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4968.

avatar infograf768
infograf768 - comment - 3 Nov 2014

@test
OK now. Thanks. Merging.

avatar infograf768 infograf768 - close - 3 Nov 2014
avatar infograf768 infograf768 - change - 3 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-03 10:15:56

Add a Comment

Login with GitHub to post a comment