User tests: Successful: Unsuccessful:
Fixed "TypeError: $(...).ready is not a function" when loading a Google Map with jQuery
To test:
jimport('jquery.framework');
$options = new JRegistry;
$options->set('autoload', 'jquery');
$google = new JGoogle($options);
$map = $google->embed('Maps');
$map->setCenter(array(48.1415102, 11.548463), 'Test');
$map->echoHeader();
$map->echoBody();
Before patch: you get the javascript error in the Console
After: map should be shown
Labels |
Added:
?
|
Travis does not like it:
1) JGoogleEmbedMapsTest::testGetHeader
Failed asserting that '' contains "$(document).ready(".
Screens made before and after the patch, Joomla! Version 3.3.7_dev
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4968.
@infograf768 I updated the test case, Travis should work now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4968.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-03 10:15:56 |
@test
works as described
Add
#map_canvas{ width:100%; height:100%; }inside HEAD during test!