? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Oct 2014

As noted by @wilsonge here: #4902 (comment)

So i hopefully correct convert the old if ($db->getErrorNum()) to Throw a RuntimeException.

Can you have a look into it @wilsonge?

avatar zero-24 zero-24 - open - 24 Oct 2014
avatar jissues-bot jissues-bot - change - 24 Oct 2014
Labels Added: ?
avatar zero-24 zero-24 - change - 24 Oct 2014
Title
Throw a RuntimeException if the db function fails in script.php
Try catch if the db function fails in script.php
avatar wilsonge
wilsonge - comment - 24 Oct 2014

Looks good to me :)

avatar zero-24 zero-24 - change - 25 Oct 2014
Title
Throw a RuntimeException if the db function fails in script.php
Try catch if the db function fails in script.php
avatar wilsonge
wilsonge - comment - 25 Oct 2014

@mbabker good to go now?

avatar zero-24 zero-24 - change - 27 Nov 2014
Status Pending Closed
avatar zero-24 zero-24 - close - 27 Nov 2014
avatar zero-24 zero-24 - close - 27 Nov 2014
avatar zero-24 zero-24 - change - 27 Nov 2014
Closed_Date 0000-00-00 00:00:00 2014-11-27 18:49:41
avatar zero-24 zero-24 - head_ref_deleted - 27 Nov 2014

Add a Comment

Login with GitHub to post a comment