? Success

User tests: Successful: Unsuccessful:

avatar b92
b92
24 Oct 2014

Steps to reproduce the issue

Call index.php?option=com_tags&view=tag&layout=list&id[0]=3
and check the HTML produce with http://validator.w3.org/check

Expected result

NO error !

Actual result

div error

System information (as much as possible)

Joomla! 3.3.6

avatar b92 b92 - open - 24 Oct 2014
avatar jissues-bot jissues-bot - change - 24 Oct 2014
Labels Added: ?
avatar b92
b92 - comment - 24 Oct 2014

Summary : deleted one from lis_items.php and added on into list.php (to have it on the right place and no W3C validator issue)

avatar brianteeman brianteeman - change - 26 Oct 2014
Category Tags
avatar wilsonge
wilsonge - comment - 26 Oct 2014

What testing data was installed for this check? As you have a specific ID presumably you must have some data?

avatar b92
b92 - comment - 26 Oct 2014

With the demo data provided (data to test joomla) with Joomla 3.3.6 (with 4 tags) you can reproduce the issue. Once intalled : from the font-end => menu 'All Front End Views' / 'Compact tagged'. Use the HTML result and check with the W3C validator an you will found the errors related into #4926 & #4924

avatar b92
b92 - comment - 26 Oct 2014

With the demo data provided (data to test joomla) with Joomla 3.3.6 (with 4 tags) you can reproduce the issue. Once intalled : from the font-end => menu 'All Front End Views' / 'Compact tagged'. Use the HTML result and check with the W3C validator an you will found the errors related into #4926 & #4924

avatar wilsonge
wilsonge - comment - 26 Oct 2014

So the sample testing data right? (there are like 4 different types which is why I'm checking :))

avatar b92
b92 - comment - 26 Oct 2014

yes, with the sample testing data (if I understand well ..:-) )

avatar wilsonge
wilsonge - comment - 26 Oct 2014

Awesome ty!

avatar infograf768
infograf768 - comment - 2 Nov 2014

Looks OK here.

avatar wilsonge
wilsonge - comment - 2 Nov 2014

Hi,
I can't replicate the div error in w3. I checked the above url with and without an item assigned to the tag there were no errors (admittedly this is with an existing website - but I changed template back to protostar to test with so there shouldn't have been a problem). I'll test again on a completely fresh install later - but I really don't think there's gonna be a difference.

Also I presume with the changes you make the div on line 50 should also be removed for when there are no tagged items.

avatar b92
b92 - comment - 2 Nov 2014
  • With de demo install (Test English (GB) Sample Data) I obtain (4 errors) with the W3C validator:

Line 139, Column 70: The headers attribute on the element td refers to the ID categorylist_header_title, but there is no th element with that ID in the same table.

Line 146, Column 16: End tag div seen, but there were open elements.

Line 106, Column 130: Unclosed element form.
…om33-2/index.php/compact-tagged" method="post" name="adminForm" id="adminForm">

Line 148, Column 8: Stray end tag form.

This with or without tags

avatar b92
b92 - comment - 2 Nov 2014

With Tags there is more errors!

avatar infograf768
infograf768 - comment - 3 Nov 2014

@wilsonge
With or without items the closing div is necessary imho in list.php as otherwise it is included only when there are items

<?php if ($this->items == false || $n == 0) : ?>
        <p> <?php echo JText::_('COM_TAGS_NO_ITEMS'); ?></p></div>
    <?php else : ?>
        <table
[...]
</table></div>
    <?php endif; ?>
avatar b92
b92 - comment - 3 Nov 2014

Reading the last comment from finfograf768, I saw an extra , so I deleted a 2° into list_item.php (line 50) for the 'no items case'.

avatar infograf768 infograf768 - close - 7 Nov 2014
avatar infograf768 infograf768 - change - 7 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-07 07:39:22

Add a Comment

Login with GitHub to post a comment