[#491] - Add params to codemirror
- Closed
- 5 Oct 2013
- Medium
- Build: master
- # 491
- Diff
- okonomiyaki3000:codemirror_fonts
- Foreign ID 28807
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
so that the user can select a font, size, and line-height.
It's for this:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8549&tracker_item_id=28807
But, as a bonus, it also solves this:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29467
I bet you all can't wait to start using "Press Start 2P"!
What this GitHub thingy is missing is a feature to vote for/against pull requests...
from here ;)
Please alpha order the new lang strings.
I think this is pretty much ready to go.
As if this PR wasn't already cool enough, now it passes PHPCS!
Any news on this being added to the next release ?
Yeah, for real, son.
phproberto
-
This is a pretty great patch.