[#490] - Fix [29470] hathor submenu+ several other issues in Hator
- Closed
- 17 Oct 2012
- Medium
- Build: master
- # 490
- Diff
- shumisha:fix_hathor_sidebar
- Foreign ID 29470
User tests: Successful: Unsuccessful:
This pr first fixes http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29470.
Then it also:
- fix missing filters in Hathor overrides of manage view of com_installer
- fix missing override of com_categories default_batch sub templates, causing chosen.css to be loaded and select lists to have wrong styles
Hi Michael. You could not "keep the module working". It suffered the same issue that caused its removal from the main cms branch. I actually never saw Hathor design with sub menu, so I first simply restoredbthe full functinality, and it looked 'ok' to me. Can you elaborate on what's not working with tabs?
It works, but the styling is way off.
With this patch - http://awesomescreenshot.com/0a6inqq9d
From 2.5 - http://awesomescreenshot.com/01ainqu27
To assume the position that you're proposing, the styling should change IMO. It just doesn't look right in that spot.
Sorry if I've come across a little harsh at times. Working hard, not a lot of sleep, and been easily irritable as of late.
I know that, close to 5am here. Styling doesn't look way off though. Won't be be able to work again on this again before a couple of days though
Follow up: had a quick look, styling changes don't look so simple to me, so if anyone can step in, that's more likely to bring this fix to completion. Thanks
Committed with eclipse. Thanks.
Hathor's submenu has never been designed to be loaded within the component area, which was the reason we had to keep mod_submenu working. Yes, the submenu is restored, but if it is going to be below the toolbar as you've placed it, within the component area, the styling needs to change. The tab styling does not work here anymore.