? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
22 Oct 2014

Some infos

Mootools document.id() :

The document.id function has a dual purpose: Getting the element by its id, and making an element in Internet Explorer "grab" all the Element methods. It also serves as a shorthand for document.getElementById().
For the full description please read the mootools documentation here: http://mootools.net/docs/core/Element/Element

Now about the part with Internet Explorer:

In IE8 Standards mode, getElementById performs a case-sensitive match on the ID attribute only. In IE7 Standards mode and previous modes, this method performs a case-insensitive match on both the ID and NAME attributes, which might produce unexpected results.
For the reference please visit MSDN: http://msdn.microsoft.com/en-us/library/ie/ms536437(v=vs.85).aspx

Another good reference for compatibility is: http://quirksmode.org/dom/core/

screenshot 2014-10-21 17 15 41

Conclusion: Since IE8 all browsers give the same response on the method documet.getElementById()

Joomla 3.x supports IE>8

  1. That makes the usage of this legacy mootools dependent code useless
  2. The form validation script is now a jQuery script. So it doesn’t really makes any sense to have mootools code for submitting a form and jquery code to validate it.

Anyhow this PR will not go to the actual behavior, will just make all the document.id() vanilla, since there is absolutely NO compatibility issue.

Tests

Because the two methods ARE IDENTICAL it’s more a review for typos, but if the team thinks otherwise then to complete the tests you have to go in every form, button in the back end and check that functionality is still in place.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar dgt41 dgt41 - open - 22 Oct 2014
avatar jissues-bot jissues-bot - change - 22 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Oct 2014
Category JavaScript
avatar dgt41
dgt41 - comment - 8 Nov 2014

UPDATE

This PR now touches only the inline scripts.
Also it brings #4517 to hathor’s override file

Still should be good to go just by reviewing it ????

avatar wilsonge
wilsonge - comment - 8 Nov 2014

I'll get some testers for this in the PBF tonight at JWC if I can! Thanks for waiting so long with this man!!

avatar dgt41
dgt41 - comment - 8 Nov 2014

@wilsonge George I made a change in behavior.php and introduce another function formvalidator so that the old one formvalidation still works as is.
I will try and push the code for all the backend, frontend to use the new one and also not being inline scripts but use the jQuery(document).ready(function() { …}
This will also allow for another major milestone: scripts to bottom!!!
But this is still good to go!!!

308d1d9 8 Nov 2014 avatar dgt41 CS
avatar dgt41
dgt41 - comment - 8 Nov 2014

@wilsonge I re-pushed this one so now is clean. This will only touch inline scripts and not the code for form submission, for that a made a bunch of PR’s ????

avatar anibalsanchez
anibalsanchez - comment - 12 Nov 2014

@test OK

Tested with CRUD and Batch operations in Users, Articles, Categories, Banners, Languages, Menu, Messages, Modules, Newsfeeds, Plugins and Contacts.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.

avatar anibalsanchez anibalsanchez - test_item - 12 Nov 2014 - Tested successfully
avatar roland-d
roland-d - comment - 18 Nov 2014

@test: Tested and code reviewed the changes. All is successful.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.

avatar roland-d roland-d - test_item - 18 Nov 2014 - Tested successfully
avatar roland-d roland-d - change - 18 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 18 Nov 2014

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.

avatar infograf768 infograf768 - change - 29 Nov 2014
Milestone Added:
avatar infograf768 infograf768 - reference | ad31fab - 29 Nov 14
avatar infograf768 infograf768 - merge - 29 Nov 2014
avatar infograf768 infograf768 - close - 29 Nov 2014
avatar infograf768 infograf768 - change - 29 Nov 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-11-29 08:03:35
avatar infograf768 infograf768 - close - 29 Nov 2014
avatar dgt41 dgt41 - head_ref_deleted - 11 Dec 2014

Add a Comment

Login with GitHub to post a comment