User tests: Successful: Unsuccessful:
The document.id function has a dual purpose: Getting the element by its id, and making an element in Internet Explorer "grab" all the Element methods. It also serves as a shorthand for document.getElementById().
For the full description please read the mootools documentation here: http://mootools.net/docs/core/Element/Element
In IE8 Standards mode, getElementById performs a case-sensitive match on the ID attribute only. In IE7 Standards mode and previous modes, this method performs a case-insensitive match on both the ID and NAME attributes, which might produce unexpected results.
For the reference please visit MSDN: http://msdn.microsoft.com/en-us/library/ie/ms536437(v=vs.85).aspx
Another good reference for compatibility is: http://quirksmode.org/dom/core/
Anyhow this PR will not go to the actual behavior, will just make all the document.id() vanilla, since there is absolutely NO compatibility issue.
Because the two methods ARE IDENTICAL it’s more a review for typos, but if the team thinks otherwise then to complete the tests you have to go in every form, button in the back end and check that functionality is still in place.
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
I'll get some testers for this in the PBF tonight at JWC if I can! Thanks for waiting so long with this man!!
@wilsonge George I made a change in behavior.php and introduce another function formvalidator so that the old one formvalidation still works as is.
I will try and push the code for all the backend, frontend to use the new one and also not being inline scripts but use the jQuery(document).ready(function() { …}
This will also allow for another major milestone: scripts to bottom!!!
But this is still good to go!!!
@test OK
Tested with CRUD and Batch operations in Users, Articles, Categories, Banners, Languages, Menu, Messages, Modules, Newsfeeds, Plugins and Contacts.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.
@test: Tested and code reviewed the changes. All is successful.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4895.
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-29 08:03:35 |
UPDATE
This PR now touches only the inline scripts.
Also it brings #4517 to hathor’s override fileStill should be good to go just by reviewing it????