[#48806] - [6.2] [AI] Load the library language in extension:install
- Pending
- Medium
- Build: 6.2-dev
- # 48806
- Diff
- smarta-lab:fix-39267-cli-language
User tests: Successful: Unsuccessful:
The command never loaded lib_joomla, so strings of the installer stayed untranslated in the CLI. A template installed this way got the style title JLIB_INSTALLER_DEFAULT_STYLE instead of " - Default".
Fixes #39267
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
extension:install never loads lib_joomla, so strings of the installer stay
untranslated in the CLI. The command now loads the language file when it starts,
like core:update and update:extensions:check already do.
Testing Instructions
- Take the ZIP file of a site template that is not installed yet.
- Run
php cli/joomla.php extension:install --path=/path/to/template.zip. - Open System > Site Templates Styles and look at the title of the new style.
Actual result BEFORE applying this Pull Request
The title of the style is JLIB_INSTALLER_DEFAULT_STYLE.
Expected result AFTER applying this Pull Request
The title of the style is <template name> - Default.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 61bd90d
Thanks for adding extension:discover:install.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48806.
I have tested this item ✅ successfully on 61bd90d
Minimal site templates installed via CLI, title of the new style (before = base version of the command):
extension:install --path=…JLIB_INSTALLER_DEFAULT_STYLE<name> - Defaultextension:install --url=…<name> - Defaultextension:discover:installJLIB_INSTALLER_DEFAULT_STYLEJLIB_INSTALLER_DEFAULT_STYLESuggestion:
extension:discover:installhas the same bug (the template adapter creates the style forinstallanddiscover_install). Adding the same line toExtensionDiscoverInstallCommand::configureIO()fixes it, tested with and without--eid: