User tests: Successful: Unsuccessful:
Pull Request resolves #48759
Root Cause:
ModulesHelper::getTranslatedModulePosition() previously called Text::_($langKey) before checking if the language key existed, and relied on self::isTranslatedText() ($text !== $langKey) to trigger fallbacks. With Language Debug enabled, Text::_() wraps missing keys in ??...??, causing $text !== $langKey to evaluate to true and skip all fallbacks.ModulesHelper nor PositionsModel checked templateDetails.xml for a <parent> template, meaning child templates could not inherit position language keys from their parent template.How this PR addresses the root cause:
1. ModulesHelper::getTranslatedModulePosition():
<parent> template, and loads the parent template's tpl_<parent>.sys.ini file.
$lang->hasKey() before calling Text::_() so missing keys do not show up as untranslated in the Language Debug logs.2. ModulesHelper::isTranslatedText():
$text !== '??' . $langKey . '??' so strings wrapped by Language Debug are properly recognized as untranslated.3.PositionsModel::getItems():
Strings are appropriately translated.

Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_modules |
I have tested this item ✅ successfully on 1c3a9e8
Hi @hiteshm0, I was able to successfully test this PR fix.
For other tester, a required/important addition to the testing instructions, you must 1st go into Global Configuration and enable Debug Language in the System tab.
I have tested this item ✅ successfully on 1c3a9e8
I have tested this item ✅ successfully on 1c3a9e8
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.2-dev
|
||
RTC
RTC
I have tested this item ✅ successfully on 1c3a9e8
Hi @hiteshm0, I was able to successfully test this PR fix.
For other tester, a required/important addition to the testing instructions, you must 1st go into Global Configuration and enable Debug Language in the System tab.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.