PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar hiteshm0
hiteshm0
7 Nov 2026

Pull Request resolves #48759

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Root Cause:

  1. ModulesHelper::getTranslatedModulePosition() previously called Text::_($langKey) before checking if the language key existed, and relied on self::isTranslatedText() ($text !== $langKey) to trigger fallbacks. With Language Debug enabled, Text::_() wraps missing keys in ??...??, causing $text !== $langKey to evaluate to true and skip all fallbacks.
  2. Neither ModulesHelper nor PositionsModel checked templateDetails.xml for a <parent> template, meaning child templates could not inherit position language keys from their parent template.

How this PR addresses the root cause:
1. ModulesHelper::getTranslatedModulePosition():

  • Parses templateDetails.xml to detect if a template has a <parent> template, and loads the parent template's tpl_<parent>.sys.ini file.
  • Checks $lang->hasKey() before calling Text::_() so missing keys do not show up as untranslated in the Language Debug logs.
  • Adds a parent template translation fallback (Child Template $\rightarrow$ Parent Template $\rightarrow$ com_modules $\rightarrow$ humanized position name) and strips the parent template prefix when humanizing position names.

2. ModulesHelper::isTranslatedText():

  • Explicitly checks $text !== '??' . $langKey . '??' so strings wrapped by Language Debug are properly recognized as untranslated.

3.PositionsModel::getItems():

  • Loads tpl_.sys.ini when is present in templateDetails.xml and falls back to TPL_POSITION* before COM_MODULES_POSITION_*

Testing Instructions

  1. Go into Global Configuration and enable Debug Language in the System tab.
  2. Go to System $\rightarrow$ Site Templates $\rightarrow$ Styles.
  3. Find Cassiopeia Extended - Default.
  4. If its star in the Default column is not selected, click it. The selected star marks the default site template style.
  5. Go to content $\rightarrow$ site modules and select a module
  6. Select the positions dropdown

Actual result BEFORE applying this Pull Request

Untranslated strings.
image

Expected result AFTER applying this Pull Request

Strings are appropriately translated.
image

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar hiteshm0 hiteshm0 - open - 7 Nov 2026
avatar hiteshm0 hiteshm0 - change - 7 Nov 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2026
Category ⇒ Administration com_modules
avatar exlemor exlemor - test_item - 7 Nov 2026 - Tested successfully
avatar exlemor
exlemor - comment - 7 Nov 2026

I have tested this item ✅ successfully on 1c3a9e8

Hi @hiteshm0, I was able to successfully test this PR fix.

For other tester, a required/important addition to the testing instructions, you must 1st go into Global Configuration and enable Debug Language in the System tab.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar exlemor
exlemor - comment - 7 Nov 2026

I have tested this item ✅ successfully on 1c3a9e8

Hi @hiteshm0, I was able to successfully test this PR fix.

For other tester, a required/important addition to the testing instructions, you must 1st go into Global Configuration and enable Debug Language in the System tab.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar tecpromotion tecpromotion - test_item - 7 Nov 2026 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 7 Nov 2026

I have tested this item ✅ successfully on 1c3a9e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar tecpromotion
tecpromotion - comment - 7 Nov 2026

I have tested this item ✅ successfully on 1c3a9e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar tecpromotion tecpromotion - change - 7 Nov 2026
The description was changed
Status Pending ⇒ Ready to Commit
Labels Added: PR-6.2-dev
avatar tecpromotion
tecpromotion - comment - 7 Nov 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar tecpromotion tecpromotion - edited - 7 Nov 2026
avatar tecpromotion
tecpromotion - comment - 7 Nov 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48805.

avatar hiteshm0 hiteshm0 - change - 7 Nov 2026
The description was changed
avatar hiteshm0 hiteshm0 - edited - 7 Nov 2026

Add a Comment

Login with GitHub to post a comment