[#48801] - [6.2] Install from Web scroll [a11y] [ux]
- Ready to Commit
- Medium
- Build: 6.2-dev
- # 48801
- Diff
- brianteeman:installfromwebscroll
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Fix the scroll position when navigating to an extension's details in the Joomla Web Installer.
Also fixes the scroll position when changing category so you are positioned at the top when you change category
Testing Instructions
This is a js change so either use a prebuilt package or npm i
Go to the Install from web tab of the extension installer
Scroll right to the bottom and click on one of the extensions
And
Go to the Install from web tab of the extension installer
Scroll to the bottom of the category menu and select a menu item
Actual result BEFORE applying this Pull Request
The extension details page opens but you are scrolled right to the bottom of the page and you need to scroll up many times to get to the useful information
thorium_dWd4taWDYm.mp4
For category changes you are still scrolled at the bottom
Expected result AFTER applying this Pull Request
The extension details page opens and you are scrolled to the top
thorium_3LVNfDN1X6.mp4
For category changes you are now scrolled to the top of the newly selected category
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript NPM Change |
I have tested this item ✅ successfully on d2c197b
I was able to test this successfully during Nov. 6th - Happy PR Friday testing session.
Thank you @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
I have tested this item ✅ successfully on d2c197b
Suggestion: opening a category has the same cause and isn't covered. Adding it fixes that too (tested):
if (webInstallerOptions.view === 'extension' || webInstallerOptions.view === 'category') {
window.scrollTo(0, 0);
}
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/48801">issues.joomla.org/tracker/joomla-cms/48801</a>.</sub>
I have tested this item ✅ successfully on d2c197b
Suggestion: opening a category has the same cause and isn't covered. Adding it fixes that too (tested):
if (webInstallerOptions.view === 'extension' || webInstallerOptions.view === 'category') {
window.scrollTo(0, 0);
}
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/48801">issues.joomla.org/tracker/joomla-cms/48801</a>.</sub>
I will test and add that to this pr shortly
@exlemor @tecpromotion I have updated the PR and test instructions to also cover the case of selecting an extension category at the bottom of the list so that you are scrolled to the top when you select another category. Please can you retest that change as well
@brianteeman Thanks! The test instructions are updated, but I don't see a new commit yet: the PR (and installfromwebscroll in your fork) is still at d2c197b from yesterday. Maybe the push is missing? I'll retest once it's there.
| Labels |
Added:
a11y
NPM Resource Changed
UI/UX
PR-6.2-dev
|
||
Oops I forgot to commit.
I have tested this item ✅ successfully on f8b26ae
Thanks for adding the category case.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
I have tested this item ✅ successfully on f8b26ae
Thanks for adding the category case.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
I have tested this item ✅ successfully on f8b26ae
I have retested this successfully for both the initial scroll for an extension and the category. Thank you very much @brianteeman for the thoroughness.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
I have tested this item ✅ successfully on f8b26ae
I have retested this successfully for both the initial scroll for an extension and the category. Thank you very much @brianteeman for the thoroughness.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.
I have tested this item ✅ successfully on d2c197b
I was able to test this successfully during Nov. 6th - Happy PR Friday testing session.
Thank you @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48801.