[#48793] - [6.2] Fix accessibility of install extensions from web [a11y]
- Pending
- Medium
- Build: 6.2-dev
- # 48793
- Diff
- Raheem54:fix_accessibility_of_install_ext_from_web
User tests: Successful: Unsuccessful:
Pull Request resolves #48410 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Make of extensions in install from web accessible with keyboard
Testing Instructions
- Open System -> Extensions -> Install from web tap
- Try access the extensions in both grid and list view with keyboard and enter
Actual result BEFORE applying this Pull Request
you can't access the apps with screen reader and keyboard
Expected result AFTER applying this Pull Request
you can access the apps with keyboard and screen reader due to change its role to link
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
I can confirm it works but I dont know enough to confirm it is now fully accessible - but I will mark it as a successful test as its definitely more accessible now than it was before
joomla-cms-bot
- | Category | ⇒ | JavaScript NPM Change |
I think it's now achieve the purpose of keyboard and reader accessible with the simplest way, I think the another way is to change it from install from web repo to <a> and change js here to handle that change but I preferred the first solution as it at least achieved the goal without edit in more places, at the end waiting for reviewers opinion.
I have tested this successfully but for some reason I couldn't mark it as successful in the Joomla Issue Tracker as there was no Test this / Alter this button ;( (sorry).
@exlemor Is this a general issue for all of trying to make it successful test and I have to remake the PR or just for you ?
There was an issue with Joomla Issue Tracker yesterday which affected this and a few other PRs, but I don't think you will need to re-do your PR. A release manager will say so if it is needed. :)
I have tested this item ✅ successfully
Live JED catalogue, keyboard only, before = base client.min.js:
| Before | After | |
|---|---|---|
| Cards reachable with Tab | 0 | all, grid and list, also after category/search |
| Role (accessibility tree) | generic |
link |
| Enter | – | opens the details |
Branch: this is a bug fix (WCAG 2.1.1) and client.es6.js is identical in 6.2-dev, so please retarget to 6.2-dev like the other a11y audit fixes.
Suggestion: the link name is the whole div text. Grid: name + C M P + ~400 characters of description. List: only the description, without the extension name (the <h4> is outside the div there). The issue asks for a name that contains the extension name. This gives link, Akeeba Backup in both views (tested):
const title = element.closest('.item')?.querySelector('h4');
if (title) {
element.setAttribute('aria-label', title.textContent.trim());
}
| Labels |
Added:
a11y
NPM Resource Changed
PR-6.3-dev
|
||
thanks, now aria-label added and the branch changed
| Title |
|
||||||
| Category | JavaScript NPM Change | ⇒ | JavaScript Libraries Unit Tests Administration Front End Installation Language & Strings Repository com_config NPM Change |
![avatar github-actions[bot]](/images/avatars/github-actions%5Bbot%5D.png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Unit/System Tests
Language Change
Conflicting Files
PR-6.2-dev
|
||
| Category | JavaScript NPM Change Libraries Unit Tests Administration Front End Installation Language & Strings Repository com_config | ⇒ | JavaScript Libraries Unit Tests Front End Installation Repository com_config NPM Change |
| Labels |
Removed:
Language Change
Conflicting Files
|
||
this update is just for joomla tracker to make it PR not issue
*this update is just for joomla tracker to make it PR not issue
*this update is just for joomla tracker to make it PR not issue and now test available
| Labels |
Removed:
PR-6.3-dev
|
||
joomla-bot
- | Category | JavaScript NPM Change Libraries Unit Tests Front End Installation Repository com_config | ⇒ | JavaScript NPM Change |
I have tested this item ✅ successfully on db5cbb4
Hello @Raheem54, success come to those who persevere and you did just that! :)
THANK YOU for your efforts, I was able to successfully test this PR fix.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48793.
I can confirm it works but I dont know enough to confirm it is now fully accessible - but I will mark it as a successful test as its definitely more accessible now than it was before