User tests: Successful: Unsuccessful:
Pull Request resolves # .
This pull request (PR) updates the composer development dependencies phpstan/phpstan and phpstan/phpstan-deprecation-rules to the same versions as currently used in the 6.2-dev branch:
phpstan/phpstan is updated from version 2.1.29 to version 2.2.2phpstan/phpstan-deprecation-rules is updated from version 2.0.3 to version 2.0.4Reason: Currently the "Run PHPstan" action fails in our CI workflow with 3 errors Call to deprecated method getError\(\) of class Joomla\\CMS\\MVC\\Model\\BaseModel\.
They are not new, nothing has been changed in the corresponding code, but they were not reported before.
When you add them to the phpstan-baseline.neon file, the CI action passes, but then the CI action removes the new entries from the baseline file with the Updated PHPStan baseline commit.
You can see that in my closed PR: https://github.com/joomla/joomla-cms/pull/48744/commits
I have not found any explanation for that, no mistake in the ci.yml in my opinion.
In 6.2-dev this does not happen with their newer versions of the phpstan dependencies.
Therefore this PR here to fix that issue.
I could also have updated the 2 dependencies to meanwhile available newer versions (phpstan/phpstan to 2.3.4 and phpstan/phpstan-deprecation-rules to 2.0.5), but then we have to do the same in the 6.2-dev and upper branches, too, so they won't have a downgrade.
I've decided against that and think if we do that, we should do it with a separate PR.
Check the "Run PHPstan" action of our CI workflow.
Fails for the last commit of the 5.4-dev branch, see https://github.com/joomla/joomla-cms/actions/runs/41334221346/job/124963875630
Succeeds for this PR here.
No additional commit Updated PHPStan baseline is created for this PR here.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | External Library Composer Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-11-02 21:57:08 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
Composer Dependency Changed
PR-5.4-dev
|
||
Was thought as a replacement for PR 48748 as Drone does not start for that PR. But this one here has the same problem, so using a new branch does not help.
Closing.