? Success
Related to # 4874
Referenced as Related to: # 4876 # 4877

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
21 Oct 2014

In Joomla 3.3.6 and 3.3.7 the Plugin "Button - Article" (plugin type: editors-xtd) is protected and cannot be unpublished.

Steps to reproduce the issue

Install Joomla 3.3.6 or 3.3.7,
Go to Extensions > Extension Manager > Manage
Search for editor-xtd plugins (Filter: Type = plugin, Folder = editors-xtd)
It will show 4 editor-xtd plugins, the "Button - Article" plugin is marked as "protected".

Expected result

I use JCE editor and from usability point of view, would like to unpublish all unused buttons that are displayed below the editor. In previous versions I was able to unpublish all 4 "Buttons".

Actual result

All buttons, except the "Button - Article", can be unpublished.
The "Button - Article" is marked as protected.

System information (as much as possible)

avatar pe7er pe7er - open - 21 Oct 2014
avatar jissues-bot jissues-bot - change - 21 Oct 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 21 Oct 2014

You can disable it via the Plugins manager.

avatar brianteeman brianteeman - change - 21 Oct 2014
Category Installation Plugins UI/UX
avatar brianteeman brianteeman - change - 21 Oct 2014
Rel_Number 4874
Relation Type Related to
avatar brianteeman brianteeman - change - 21 Oct 2014
The description was changed
avatar pe7er
pe7er - comment - 21 Oct 2014

Yes, thanks. I just found out that it still works via Plugin Manager (which I usually use to unpublish).
This time I was using the Extension Manager and was confused that I couldn't do it via Extension Manager > Manage

Why is the plugin plg_editors-xtd_article "protected" and the other three xtd-editor plugins aren't?

avatar Bakual
Bakual - comment - 21 Oct 2014

I agree that it doesn't make sense to have this plugin protected. You should actually be able to even uninstall it without causing any issues.

avatar infograf768
infograf768 - comment - 21 Oct 2014

@pe7er
you also should unprotect it in the other db

avatar pe7er
pe7er - comment - 21 Oct 2014

Good point JM!

Patch for MSSQL: #4876
Patch for PostgreSQL: #4877

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4875.

avatar zero-24 zero-24 - change - 21 Oct 2014
Category Installation Plugins UI/UX Installation Plugins SQL UI/UX
avatar sovainfo
sovainfo - comment - 21 Oct 2014

Unprotecting should only be done when it allows install after uninstall.

avatar zero-24
zero-24 - comment - 21 Oct 2014

@sovainfo

I think it should work with the Discover option. (BE --> Extensions --> Extension Manager --> Tab:Discover)
But i have not tested.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4875.

avatar sovainfo
sovainfo - comment - 21 Oct 2014

Knew that, problem is that doesn't work always. My issue was not to unprotect in those situations.

In the mean time I tested it and it does work. At least if you restore the plugin and the language files for the plugin in administrator/languages.

@test Ok, Issue confirmed, PR solves issue
Tested by phpMyAdmin unprotecting. Uninstalled using Extension manager->Manage->Uninstall.
Restored plugin from distribution. Discover->Install. Noticed missing language files. Restored them as well. Checked functionality by creating new article using button to insert article reference. Checked editting existing article inserting reference. Both worked fine.

avatar Bakual
Bakual - comment - 21 Oct 2014

Related PRs for the other dbs:
#4877
#4876

avatar zero-24
zero-24 - comment - 21 Oct 2014

@pe7er @Bakual do we need to update it also on updates? So write should / need we a SQL file for updates?

avatar Bakual
Bakual - comment - 21 Oct 2014

Good point with the updates!

avatar dgt41
dgt41 - comment - 21 Oct 2014

:+1:

avatar brianteeman
brianteeman - comment - 13 Nov 2014

Please test the related patches

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4875.

avatar dgt41
dgt41 - comment - 13 Nov 2014

@test pass

Before:

screen shot 2014-11-13 at 6 55 42
screen shot 2014-11-13 at 6 55 30

After:

screen shot 2014-11-13 at 6 56 11
screen shot 2014-11-13 at 6 56 28

avatar Bakual
Bakual - comment - 13 Nov 2014

As noted by @zero-24, this needs also an update SQL query. Otherwise it has no effect on existing installations.
Also it needs to be done for PostgreSQL and MS SQL as well.

avatar pe7er
pe7er - comment - 3 Dec 2014

PR for Updates: #4877 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4875.

avatar wilsonge wilsonge - close - 18 Jan 2015
avatar wilsonge wilsonge - change - 18 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-18 00:44:57

Add a Comment

Login with GitHub to post a comment