RTC NPM Resource Changed PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Oct 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The js used to build the color custom field was incomplete and did not generate the field correctly when RTL

Testing Instructions

This is a js change so either use a prebuilt package or apply the pr and npm i

Create a custom field of type color

Test the display of the field in both an LTR language and an RTL language

Actual result BEFORE applying this Pull Request

LTR Language

image

RTL Language

image

Expected result AFTER applying this Pull Request

LTR Language

image

RTL Language

image

Note

The original file was incorrectly using tabs and not spaces so GH shows every line as changed

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 30 Oct 2026
avatar brianteeman brianteeman - change - 30 Oct 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2026
Category ⇒ JavaScript NPM Change
avatar exlemor exlemor - test_item - 30 Oct 2026 - Tested successfully
avatar exlemor
exlemor - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

I was able to test this successfully just now. Thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.

avatar exlemor
exlemor - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

I was able to test this successfully just now. Thanks @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.

avatar tecpromotion tecpromotion - test_item - 30 Oct 2026 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

Verdict: works as intended.

In RTL the swatch now sits next to the value at the start of the field and the panel opens right-aligned, mirroring LTR. LTR is unchanged.

Verification

Fresh 6.2-dev install (DDEV), advanced colour field (custom field of type Colour in an article + Atum "Colour Settings"), RTL via <rtl>1</rtl> in the admin en-GB metadata. Measured after opening the picker:

before RTL after RTL LTR before = after
position class left right default
swatch left edge, value at right edge right edge, next to value left, next to value
panel left-aligned right-aligned left-aligned

Suggestion (non-blocking)

ColorField::getLayoutData() (line 253) already turns default into left for RTL ("default RTL is left"), and the JS now flips that back to right. The comment there is misleading now; maybe let PHP pass default and keep the RTL mapping in one place.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar tecpromotion
tecpromotion - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

Verdict: works as intended.

In RTL the swatch now sits next to the value at the start of the field and the panel opens right-aligned, mirroring LTR. LTR is unchanged.

Verification

Fresh 6.2-dev install (DDEV), advanced colour field (custom field of type Colour in an article + Atum "Colour Settings"), RTL via <rtl>1</rtl> in the admin en-GB metadata. Measured after opening the picker:

before RTL after RTL LTR before = after
position class left right default
swatch left edge, value at right edge right edge, next to value left, next to value
panel left-aligned right-aligned left-aligned

Suggestion (non-blocking)

ColorField::getLayoutData() (line 253) already turns default into left for RTL ("default RTL is left"), and the JS now flips that back to right. The comment there is misleading now; maybe let PHP pass default and keep the RTL mapping in one place.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar alikon alikon - change - 30 Oct 2026
The description was changed
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 30 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.

avatar alikon
alikon - comment - 30 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.

avatar brianteeman
brianteeman - comment - 30 Oct 2026

@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language

avatar brianteeman
brianteeman - comment - 30 Oct 2026

@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings ‎

avatar brianteeman
brianteeman - comment - 30 Oct 2026

@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings &#x200E;

avatar brianteeman
brianteeman - comment - 30 Oct 2026

@tecpromotion it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings &#x200E;

avatar MacJoom MacJoom - change - 30 Oct 2026
The description was changed
Labels Added: RTC NPM Resource Changed PR-6.2-dev
avatar ThomasFinnern ThomasFinnern - test_item - 30 Oct 2026 - Not tested
avatar ThomasFinnern
ThomasFinnern - comment - 30 Oct 2026

I have not tested this item.

* Checked the start situation with english and arabic language

  • Applied PR patch tester with npm ci
  • result fine in arabic and english

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar ThomasFinnern
ThomasFinnern - comment - 30 Oct 2026

I have not tested this item.

* Checked the start situation with english and arabic language

  • Applied PR patch tester with npm ci
  • result fine in arabic and english

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar ThomasFinnern ThomasFinnern - test_item - 30 Oct 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

* Checked the start situation with english and arabic language

  • Applied PR patch tester with npm ci
  • result fine in arabic and english

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar ThomasFinnern
ThomasFinnern - comment - 30 Oct 2026

I have tested this item ✅ successfully on f136067

* Checked the start situation with english and arabic language

  • Applied PR patch tester with npm ci
  • result fine in arabic and english

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.
avatar MacJoom MacJoom - change - 30 Oct 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-10-30 17:19:03
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 30 Oct 2026
avatar MacJoom MacJoom - merge - 30 Oct 2026
avatar MacJoom
MacJoom - comment - 30 Oct 2026

Thank you!

avatar brianteeman
brianteeman - comment - 30 Oct 2026

Thanks

Add a Comment

Login with GitHub to post a comment