User tests: Successful: Unsuccessful:
Pull Request resolves # .
The js used to build the color custom field was incomplete and did not generate the field correctly when RTL
This is a js change so either use a prebuilt package or apply the pr and npm i
Create a custom field of type color
Test the display of the field in both an LTR language and an RTL language
The original file was incorrectly using tabs and not spaces so GH shows every line as changed
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | JavaScript NPM Change |
I have tested this item ✅ successfully on f136067
I was able to test this successfully just now. Thanks @brianteeman!
I have tested this item ✅ successfully on f136067
Verdict: works as intended.
In RTL the swatch now sits next to the value at the start of the field and the panel opens right-aligned, mirroring LTR. LTR is unchanged.
Fresh 6.2-dev install (DDEV), advanced colour field (custom field of type Colour in an article + Atum "Colour Settings"), RTL via <rtl>1</rtl> in the admin en-GB metadata. Measured after opening the picker:
| before RTL | after RTL | LTR before = after | |
|---|---|---|---|
| position class | left |
right |
default |
| swatch | left edge, value at right edge | right edge, next to value | left, next to value |
| panel | left-aligned | right-aligned | left-aligned |
ColorField::getLayoutData() (line 253) already turns default into left for RTL ("default RTL is left"), and the JS now flips that back to right. The comment there is misleading now; maybe let PHP pass default and keep the RTL mapping in one place.
I have tested this item ✅ successfully on f136067
Verdict: works as intended.
In RTL the swatch now sits next to the value at the start of the field and the panel opens right-aligned, mirroring LTR. LTR is unchanged.
Fresh 6.2-dev install (DDEV), advanced colour field (custom field of type Colour in an article + Atum "Colour Settings"), RTL via <rtl>1</rtl> in the admin en-GB metadata. Measured after opening the picker:
| before RTL | after RTL | LTR before = after | |
|---|---|---|---|
| position class | left |
right |
default |
| swatch | left edge, value at right edge | right edge, next to value | left, next to value |
| panel | left-aligned | right-aligned | left-aligned |
ColorField::getLayoutData() (line 253) already turns default into left for RTL ("default RTL is left"), and the JS now flips that back to right. The comment there is misleading now; maybe let PHP pass default and keep the RTL mapping in one place.
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language
@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings
@tecpromotion in this specific example it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings ‎
@tecpromotion it might be ok to change the rtl value in the xml BUT the problem is that browsers are clever and will actually detect that you are using an LTR language so you are not really testing an RTL language. You can not for example test the code to force an RTL into LTR which we have to do sometimes where we have mixed strings ‎
| Labels |
Added:
RTC
NPM Resource Changed
PR-6.2-dev
|
||
I have not tested this item.
* Checked the start situation with english and arabic language
I have not tested this item.
* Checked the start situation with english and arabic language
I have tested this item ✅ successfully on f136067
* Checked the start situation with english and arabic language
I have tested this item ✅ successfully on f136067
* Checked the start situation with english and arabic language
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-10-30 17:19:03 |
| Closed_By | ⇒ | MacJoom |
Thank you!
Thanks
I have tested this item ✅ successfully on f136067
I was able to test this successfully just now. Thanks @brianteeman!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48732.