User tests: Successful: Unsuccessful:
Pull Request resolves # .
Spotted while looking for something else but the case of ishtml in the code comments doesnt match the actual case of the method being tested
looks like a remnant from a very old change upstream in phpmail
code review only
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Unit Tests |
I have tested this item ✅ successfully on 3cd5d3f
Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.
public function testIsHtmlTrue()
{
$this->mail->isHtml(true);
...
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/48703">issues.joomla.org/tracker/joomla-cms/48703</a>.</sub>
I have tested this item ✅ successfully on 3cd5d3f
Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.
public function testIsHtmlTrue()
{
$this->mail->isHtml(true);
...
I have tested this item ✅ successfully on 3cd5d3f
I have tested this item ✅ successfully on 3cd5d3f
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
Unit/System Tests
PR-6.2-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-11-04 16:59:12 |
| Closed_By | ⇒ | MacJoom |
Thank you!
Thanks
I have tested this item ✅ successfully on 3cd5d3f
Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.