RTC Unit/System Tests PR-6.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Oct 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Spotted while looking for something else but the case of ishtml in the code comments doesnt match the actual case of the method being tested

looks like a remnant from a very old change upstream in phpmail

Testing Instructions

code review only

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 26 Oct 2026
avatar brianteeman brianteeman - change - 26 Oct 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2026
Category ⇒ Unit Tests
avatar richard67 richard67 - test_item - 26 Oct 2026 - Tested successfully
avatar richard67
richard67 - comment - 26 Oct 2026

I have tested this item ✅ successfully on 3cd5d3f

Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.

public function testIsHtmlTrue()
    {
        $this->mail->isHtml(true);
...
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/48703">issues.joomla.org/tracker/joomla-cms/48703</a>.</sub>
avatar richard67
richard67 - comment - 26 Oct 2026

I have tested this item ✅ successfully on 3cd5d3f

Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.

public function testIsHtmlTrue()
    {
        $this->mail->isHtml(true);
...
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/48703">issues.joomla.org/tracker/joomla-cms/48703</a>.</sub>
avatar richard67
richard67 - comment - 26 Oct 2026

I have tested this item ✅ successfully on 3cd5d3f

Code review. The method name can bee seen when expanding the code change on GitHub so you see what's inside the test method. E.g.

public function testIsHtmlTrue()
    {
        $this->mail->isHtml(true);
...

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48703.
avatar chmst chmst - test_item - 27 Oct 2026 - Tested successfully
avatar chmst
chmst - comment - 27 Oct 2026

I have tested this item ✅ successfully on 3cd5d3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48703.

avatar chmst
chmst - comment - 27 Oct 2026

I have tested this item ✅ successfully on 3cd5d3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48703.

avatar chmst chmst - change - 27 Oct 2026
The description was changed
Status Pending ⇒ Ready to Commit
avatar chmst
chmst - comment - 27 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48703.

avatar chmst chmst - edited - 27 Oct 2026
avatar chmst
chmst - comment - 27 Oct 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48703.

avatar MacJoom MacJoom - change - 4 Nov 2026
Labels Added: RTC Unit/System Tests PR-6.2-dev
avatar MacJoom MacJoom - change - 4 Nov 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-11-04 16:59:12
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 4 Nov 2026
avatar MacJoom MacJoom - merge - 4 Nov 2026
avatar MacJoom
MacJoom - comment - 4 Nov 2026

Thank you!

avatar brianteeman
brianteeman - comment - 4 Nov 2026

Thanks

Add a Comment

Login with GitHub to post a comment