[#48697] - [6.2] install from web [a11y]
- Pending
- Medium
- Build: 6.2-dev
- # 48697
- Diff
- brianteeman:installfromweb
User tests: Successful: Unsuccessful:
Pull Request resolves #48415 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
this is a proof of concept to evaluate the approach - it is not a polished ready to merge pr
Instead of scrolling to the bottom of the page when you click on the install button a dialog is displayed instead.
Now uses the native joomla-dialog
Testing Instructions
this contains js changes so either use a pre-built package or npm i
Actual result BEFORE applying this Pull Request
thorium_nR5jcxuqyv.mp4
Expected result AFTER applying this Pull Request
thorium_eMUoNwEqwg.mp4
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
PR-6.2-dev
|
||
I have tested this item ✅ successfully on f76a296
I've tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48697.
I have tested this item ✅ successfully on f76a296
I've tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48697.
This is a WIP because
It looks ugly - help needed please- If you check the video then there is a really long delay between
clicking on the install button andthe dialog closing and the spinner loading - if I was to guess then thats the time it takes to download the file - I would expect the dialog to close and the spinner to start on click not after download - help needed please
This is a WIP because
- It looks ugly - help needed please
- If you check the video then there is a really long delay between clicking on the install button and the dialog closing and the spinner loading - if I was to guess then thats the time it takes to download the file - I would expect the dialog to close and the spinner to start on click not after download - help needed please
This is a WIP because
1.~ It looks ugly - help needed please~
2. If you check the video then there is a really long delay between clicking on the install button and the dialog closing and the spinner loading - if I was to guess then thats the time it takes to download the file - I would expect the dialog to close and the spinner to start on click not after download - help needed please
| Labels |
Added:
a11y
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on afabf86
I have successfully tested this! thanks @brianteeman - this and the other PR about Install from Web scroll together will be a really nice improvement/time savings for those that use Install from Web.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48697.
I have tested this item ✅ successfully on afabf86
I have successfully tested this! thanks @brianteeman - this and the other PR about Install from Web scroll together will be a really nice improvement/time savings for those that use Install from Web.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48697.
Oooooh—that looks nice. I like the dialog implementation a lot more, particularly because you're removing the need for a user to click the "Install" button twice in the same page (and obviously circumventing the scrolling). The dialog is a smart choice and way more manageable I think. Also, if a user presses "Cancel", then the dialog simply closes as opposed to the content being removed and focus being lost.