User tests: Successful: Unsuccessful:
document.id() The document.id function has a dual purpose: Getting the element by its id, and making an element in Internet Explorer "grab" all the Element methods. It also serves as a shorthand for document.getElementById().
For the full description please read the mootools documentation here: http://mootools.net/docs/core/Element/Element
Now about the part with Internet Explorer:
In IE8 Standards mode, getElementById performs a case-sensitive match on the ID attribute only. In IE7 Standards mode and previous modes, this method performs a case-insensitive match on both the ID and NAME attributes, which might produce unexpected results.
For the reference please visit MSDN: http://msdn.microsoft.com/en-us/library/ie/ms536437(v=vs.85).aspx
So it doesn’t really makes any sense to have mootools code for submitting a form and jquery code to validate it.
Anyhow this PR will not go to the actual behavior, will just make all the document.id() vanilla (that’s mootools NOT dependent), since there is absolutely NO compatibility issue to do so.
Because the two methods ARE IDENTICAL it’s more a review for typos, but if the team thinks otherwise then to complete the tests you have to go in every form, button in the back end and check that functionality is still in place.
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
Another good reference for compatibility is: http://quirksmode.org/dom/core/
Just in case it's not clear to the idea!
Did I manage to destroy this PR with the rebase?
Ummm I'm afraid so :(
Good think I had stashed the changes :)
Closing this one
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-22 09:57:04 |
Can we revert the two changes in FOF please? It's maintained outside of joomla (https://github.com/akeeba/fof) and is designed to have 2.5 and 3.x support