For an unknown reason (unknown to me...) this works fine except if duplicating the "Guest" viewlevel

For an unknown reason (unknown to me...) this works fine except if duplicating the "Guest" viewlevel

Could you please explain more details about it ? This PR fix that issue ? Or we will have to check the issue with "Guest" view level ?

Apparently, "Guest" is a very special level and it can be duplicated, although this PR clearly prevents it as it checks for the same title in the table.
The issue is that you can also delete/modify that Guest level and that, as far as I know, it is necessary to keep it on Joomla as is by default.

Agree that "Guest" is a special access level. However, I think if we delete it by mistake, we can re-create it. Just names it "Guest" and choose the "Guest" group for that access level and it still works?

It shouldn't matter if it's a guest viewlevel or not. You should be able to delete it or set a different one as guest without issues. It is just a setting in the user manager options which points to a certain viewlevel.

However I haven't tested if you really can change it ;)

Test this PR and you will see that we can duplicate it with the same name.
Which we can't do with a French distro not using "Guest" but "Invité" for the equivalent default view level.

I can update the PR to add a conditional
if ($db->loadResult() > 0 || $this->title == "Guest")

I tested in a default install to edit Guest and change to another name.
It saves OK.
Then I edited it again to put it back to guest.
It will not save anymore with the conditional above.

Hmm, could have been an issue here locally

Please test PR as is with a default Guest

I confirm: was a corruption on my test site. This should be OK.

Trying to add a new level "Guest" : "Save failed with the following error: Level with the name "Guest" already exists." (same message with others previous levels): patch OK for me

this should go into 3.4-dev

@test get sql error showing before when duplicate name. afterwards got language string explaining cause of issue. result successful

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4858.

Merged into 3.4.0-dev
bbad053