[#4857] - Clear old maps to fix remory leak
- Closed
- 4 Sep 2015
- Medium
- Build: staging
- # 4857
- Diff
- fastslack:router-memory-leak
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If we made multiple request using websocket, the old maps are stacked creating a memory overflow.
jissues-bot
- | Labels |
Added:
?
|
||
On a serious note though it looks like this function is designed to be called more than once as the doc block states If the pattern already exists it will be overwritten.. So not sure that is the best place to reset the variable?
How on earth are you even using this file xD
Build a separate file from index.php to handle your requirements. There's a lot you can do if you're willing to write the code :-P
@wilsonge Actually im using this file in 2 ways. One the Webservices API created by Chris Davenport:
https://github.com/chrisdavenport/j3-rest-api
And another way that im using it is with my own implementation of websocket, that call multiple request in seconds so you can look more detailed the memory leak.
https://github.com/fastslack/matware-libraries/tree/master/libraries/matware/socket
Maybe you are right, there is not the correct way to clear the variable. Creating a new method to reset the variables should be a good solution. What do you think?
zero-24
- | Category | ⇒ | Libraries |
Spoke to @fastslack and he said the issue can be closed.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-09-04 15:09:26 |
| Closed_By | ⇒ | roland-d |
How on earth are you even using this file xD