[#48505] - [6.3] fix module unclear titles
- Pending
- Medium
- Build: 6.3-dev
- # 48505
- Diff
- Raheem54:fix_module_unclear_title_63
User tests: Successful: Unsuccessful:
Pull Request resolves #48422 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
I have changed the module settings titles in forms for administrator to be clear the current module name of settings
Testing Instructions
-
Open the joomla administrator to edit different modules.
-
Inspect the browser title and document title for each page.
-
Compare each title with the visible heading and current task.
-
It should be now clear and unique .
Actual result BEFORE applying this Pull Request
When editing a module as an administrator the page title is always “Module Settings”, regardless of which module has been selected for editing.
Expected result AFTER applying this Pull Request
Each page has a unique and accurate page title with the name of the module being edited.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config Installation JavaScript NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-6.3-dev
|
||
could someone please repeat the test again as I don't know why it fails?
could someone please repeat the CI again as I don't know why it fails?
could someone please change the CI again as I don't know why it fails?
could someone please change the CI as I don't know why it fails?
I have tested this item ✅ successfully on bed8672
Hi @Raheem54. I tested this just now and all looks good to me. I used a screen reader (NVDA + Firefox) to test the page title announcements and they're well done and descriptive while installing Joomla. Additionally, the Module Settings pages are unique depending on which module is being edited.
I have no further comments on this except to congratulate you for a job well done. Your contribution to improving the accessibility of Joomla is very much appreciated. Nice work!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I have tested this item ✅ successfully on bed8672
Hi @Raheem54. I tested this just now and all looks good to me. I used a screen reader (NVDA + Firefox) to test the page title announcements and they're well done and descriptive while installing Joomla. Additionally, the Module Settings pages are unique depending on which module is being edited.
I have no further comments on this except to congratulate you for a job well done. Your contribution to improving the accessibility of Joomla is very much appreciated. Nice work!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
| Labels |
Added:
a11y
|
||
The description is not clear.
Please provide sone screenshots so that also non-developers understand add can test.
What is a user form?
The user login module or view? Any form a user can edit in frontend? Or forms for usres like profile, contact?
The description is not clear.
Please provide sone screenshots so that also non-developers understand and can test.
What is a user form?
The user login module or view? Any form a user can edit in frontend? Or forms for usres like profile, contact?
The description is not clear.
Please provide sone screenshots so that also non-developers understand and can test.
What is a user form?
The user login module or view? Any form a user can edit in frontend? Or forms for usres like profile, contact?
As you write about editing modules, it seems to be the second one. Can you confim that?
the code changed doesnt match your description
@brianteeman sorry for this mistake I think it's correct now
@brianteeman sorry for this mistake I think it's right now, but to be fully approved PR I think CI needs to be changed
yes you need to correct the failing test
| Category | Front End com_config Installation JavaScript NPM Change | ⇒ | Front End com_config Installation JavaScript NPM Change Unit Tests |
I think now it should be approved
I have corrected it, I think now should be approved
Almost but not quite
At the end of the installation you have the option to install additional languages
When you enter that page the title remains "Joomla Installer: Congratulations! Your Joomla site is ready."
Now that you have correctly added the module name in the title does it need to be repeated below - I dont think so
Almost but not quite
At the end of the installation you have the option to install additional languages When you enter that page the title remains "Joomla Installer: Congratulations! Your Joomla site is ready."
you can suggest a more suitable title for that as who reported the issue suggested it to be "Joomla Installer: complete" is that good enough or needs to clarify it more ?
if you are on the install additional languages page then the title should match that - try it and you will see what i mean
| Labels |
Added:
Unit/System Tests
|
||
sorry you misunderstood my suggestion on the module. Keep the title change and remove the part in the box which is now redundant
the install additional languages title is now correct
I have tested this item ✅ successfully on 2cf2327
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I have tested this item ✅ successfully on 2cf2327
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I am not so sure one PR should cover two separate areas?
I am not so sure one PR should cover two separate areas?
the issue was about two issues so I made this in one PR and I thought it's all about titles so no problem, but now I can modify this PR to be for installer title and make a new PR for module title
I am not so sure one PR should cover two separate areas?
the issue was about two areas so I made this in one PR and I thought it's all about titles so no problem, but now I can modify this PR to be for installer title and make a new PR for module title
I am not so sure one PR should cover two separate areas?
the issue was about two areas so I made this in one PR and I thought it's all about titles so no problem, but now I can modify this PR to be for installer title and make a new PR for module title, but I don't know if this worth it 😅?
I am not so sure one PR should cover two separate areas?
the issue was about two areas so I made this in one PR and I thought it's all about titles so no problem, now I can modify this PR to be for installer title and make a new PR for module title, but I don't know if this worth it 😅?
First of all, sorry I did not start with a big thank you but just threw in the comment :) I appreciate you PR and tested the module part successfully. I am not a maintainer so I don't know about the rules, but I have the impression PRs should only cover one area so just in case they can be also reverted for just one areas. But I might be wrong.
First of all, sorry I did not start with a big thank you but just threw in the comment :) I appreciate your PR and tested the module part successfully. I am not a maintainer so I don't know about the rules, but I have the impression PRs should only cover one area so just in case they can be also reverted for just one areas. But I might be wrong.
| Title |
|
||||||
| Category | Front End com_config Installation JavaScript NPM Change Unit Tests | ⇒ | Front End com_config JavaScript NPM Change Unit Tests |
| Category | Front End com_config JavaScript NPM Change Unit Tests | ⇒ | Front End com_config JavaScript Unit Tests |
I have tested this item ✅ successfully on f345c87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I have tested this item ✅ successfully on f345c87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I have tested this item ✅ successfully on f345c87
Nice work, @Raheem54; very nicely done! Thanks for your efforts!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
I have tested this item ✅ successfully on f345c87
Nice work, @Raheem54; very nicely done! Thanks for your efforts!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48505.
can admin please repeat the test again as I don't know why it fails?