User tests: Successful: Unsuccessful:
Pull Request resolves #48422 .
I have changed the the setup and module settings titles to be clear and relate the current step of installation and the current module name of settings
Open the frontend user-form and Joomla installation pages.
Inspect the browser title and document title for each page or step.
Compare each title with the visible heading and current task.
It should be now the same.
When editing a module, the page title is always “Module Settings”, regardless of which module has been selected for editing.
Each page has a unique and accurate page title.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End com_config JavaScript Installation |
I'm only able to test this partially in the front-end modules. When I went through the local Joomla installation method the page titles weren't sufficient (obviously pulled from the local files pre-install). The requirement of 2.4.2 Page Titled is to supply a sufficient title for user agents, which this PR does. The visual title isn't in scope, but of course updating that would be great. I think that's outside the scope of this PR though.
Can someone test the installation flow page titles, please? I didn't get a reliable result.
I'm only able to test this partially in the front-end modules. When I went through the local Joomla installation method the page titles weren't sufficient (obviously pulled from the local files pre-install). The requirement of 2.4.2 Page Titled is to supply a sufficient title for user agents, which this PR does. The visual title isn't in scope, but of course updating that would be great. I think that's outside the scope of this PR though.
Can someone test the installation flow page titles, please? I didn't get a reliable result. The image of HTML code below shows the sufficient page title in the module settings of the login form in the front-end:
| Labels |
Added:
PR-5.4-dev
|
||
that's true the issue was about the title object not the visible title, but to be visible is a great feature so I made it in the last commit and fix installer, but I don't know why CI failed
that's true the issue was about the title object not the visible title, but to be visible is a great feature so I made it in the last commit and fix installer title, but I don't know why CI failed
This's true the issue was about the title object not the visible title, but to be visible is a great feature so I made it in the last commit and fix installer title, but I don't know why CI failed
@Raheem54 Great work with the updates. Thanks for this. The only comment I have before putting a successful test on this one is that the final step of the installation, which is visually displayed as "Congratulations! Your Joomla site is ready." has a page title of "Joomla Installer" as the image below shows. A title like "Joomla Installer: Complete" or "Joomla Installer: Your Joomla site is ready" would be more complete and suitable. Is there a way to modify this?
Also, can you target 6.2-dev as the branch for this fix, please?
Again, excellent work and it looks very close to being done.
Why 6.2?
Why 6.2?
I was told that all accessibility issues from the report and their proposed fixes should target 6.2 unless they affect a tmpl, in which case it should be 6.3 And, given this does, it should be 6.3, not 6.2.
Why 6.2?
I was told that all accessibility issues from the report and their proposed fixes should target 6.2 unless they affect a tmpl, in which case it should be 6.3 And, given this does, it should be 6.3, not 6.2.
The main reason for this is a timing issue. 5.4.9 and 6.1.4 are already prepared and in testing and will be released Tuesday next week. That will also be the last 6.1.x release. 2 weeks later we will have 5.4.10 together with 6.2.0 stable, and 5.4 will go into security only support phase.
So getting all fixes into 5.4 is not really realistic, that's why we decided for 6.2-dev as target.
When tmpl files are touched, it might cause warnings about updated overrides, so for these we decided for 6.3-dev because we do not want to bother people with that in patch releases unless it is really necessary.
Surprised 6.2 is even considered at this point and it's not 6.3
| Title |
|
||||||
okay I have changed this pull to be for 5.4 and I will create a new pull for 6.2 because of many conflicts and the file structure has been changed in two versions
okay now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.1 because of many conflicts to change here, and I think this is the least version that I could modify the tmpl until now and I think the original issue version was in 6.1
okay now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.1 because of many conflicts to change here, and I think this is the latest version that I could modify the tmpl until now and I think the original issue version was in 6.1
okay now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.1 because of many conflicts to change here, and I think this is the latest version that I could modify the tmpl until now and I think the original issue version was for it
okay now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.1 (if you request that) because of many conflicts to change here, and I think this is the latest version that I could modify the tmpl until now and I think the original issue version was for it
okay @brianteeman now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.3 because of many conflicts to change here, and I think this is the version that I could modify the tmpl according to what @richard67 said
okay @brianteeman now I have changed this pull to be for 5.4 and the coming commit here is to add congratulation to title after install, I will create a new pull for 6.3 because of many conflicts to change here, and I think this is the version that I could modify the tmpl according to what @richard67 said
This is for 6.3 #48505.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-09-30 00:35:21 |
| Closed_By | ⇒ | Raheem54 |
it changes the title element but the visible title/heading on the page is still generic