[#48438] - fix: increase login support link target size
- Closed
- 6 Oct 2026
- Medium
- Build: 5.4-dev
- # 48438
- Diff
- AchalShrivastava:fix/issue-48429-login-support-links
User tests: Successful: Unsuccessful:
Pull Request resolves #48429.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
- Increased the target size of the "Need Support?" links on the Joomla Administrator login page.
- Set the links to a 24px line-height and inline-block display.
- This provides a 24px target height for the support links.
Testing Instructions
- Open the Joomla Administrator login page.
- Navigate to the "Need Support?" section.
- Inspect the Support Forum, Documentation, and News links.
- Verify that each link has a 24px height.
- Verify that the links remain visually aligned and usable.
Actual result BEFORE applying this Pull Request
The "Need Support?" links had a target height of approximately 16.5px, which did not meet the 24px minimum target size requirement.
Expected result AFTER applying this Pull Request
The "Need Support?" links have a 24px target height, improving their target size in accordance with WCAG 2.2 SC 2.5.8.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
||
Shouldnt this be more specific and on the .loginsupport and not the entire wrapper?
It's doing its work properly as mentioned in WCAG 2.2 SC 2.5.8 24px target height is there or u can explain me properly as I'm a beginner
This targets everything and anything that could be placed in the sidebar. It must be restricted to only the items you want to fix.
This targets everything and anything that could be placed in the sidebar. It must be restricted to only the items you want to fix.
Now I have done necessary changes pls review it.
I have tested this item ✅ successfully on 97d6939
I notice a shift in the entire login section compared to other standard login screens (without this PR). The entire section seems to be shifted down by some small number of pixels. I think this could be applied with more care only to the "Need Support?" section without impacting the login section. Is that fair? I marked this as successfully tested, but if this is merged, it has consequences for the UI that maintainers may take issue with. I report a successful test only as a humble tester, as the issue it is trying to resolve is indeed resolved, but with consequences. More investigation should be done.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48438.
I have tested this item ✅ successfully on 97d6939
I notice a shift in the entire login section compared to other standard login screens (without this PR). The entire section seems to be shifted down by some small number of pixels. I think this could be applied with more care only to the "Need Support?" section without impacting the login section. Is that fair? I marked this as successfully tested, but if this is merged, it has consequences for the UI that maintainers may take issue with. I report a successful test only as a humble tester, as the issue it is trying to resolve is indeed resolved, but with consequences. More investigation should be done.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48438.
I have attached two images of equal dimension demonstrating this shift. One image shows the original login screen and the other the login screen after this PR. For the sake of the issue it's trying to solve, it is solved, hence my "tested successfully" choice. Please download and compare side-by-side, as this vertical layout makes it difficult to compare:
Is anyone available to test and also decide about whether the shifting in layout is acceptable? If not, happy to help out to close this PR.
I would target the change so that it only affects the module.
I've created a new PR to target only the .loginsupport module. If that is successfully implemented, this PR can be closed.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-10-06 16:39:35 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
a11y
|
||
Shouldnt this be more specific and on the .loginsupport and not the entire wrapper?