[#48406] - Fix missing alt text for Atum logo
- Pending
- Medium
- Build: 5.4-dev
- # 48406
- Diff
- AchalShrivastava:fix/issue-48374-logo-alt
User tests: Successful: Unsuccessful:
Pull Request resolves #48374.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This pull request fixes the missing text alternative for the Atum administrator logo.
The Atum login page logo was rendered with an empty alt attribute when no custom logo alt text was configured. This made the logo inaccessible to screen reader users.
The change adds Joomla as the default alt text for both the large and small Atum logo when no custom alt text is provided.
Testing Instructions
- Open the Joomla administrator login page.
- Inspect the large and small Atum logo images.
- Verify that both images have
alt="Joomla"when no custom alt text is configured. - Verify that the logo is correctly announced by a screen reader.
Actual result BEFORE applying this Pull Request
The Atum logo on the administrator login page had an empty alt attribute:
alt=""
This provided no meaningful text alternative for screen reader users.
Expected result AFTER applying this Pull Request
The Atum logo has a meaningful default text alternative:
alt="Joomla"
This allows screen reader users to identify the logo.
Link to documentations
Please select:
- No documentation changes for guide.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
PR-5.4-dev
|
||
Sorry but this is wrong. You havent understood the reported issue.
Can you explain me sir
Thanks for putting this PR together, but I do worry that it is incomplete. The scope of the issue that you're trying to resolve includes links within the Atum template and not just the logo image on the login page. The biggest concern is that when the Joomla! logo functions as a link within the Atum templates, it needs consistent labelling so it is provided to assistive technology users in the same way every time. Often, people who use screen readers use repetitive controls to get oriented on a page, so something inconsistent can be problematic. For example, the logo image is also not linked on the main dashboard page, but linked on other pages.
In addition the visible label of the link is not included in the accessible name of the link. This means that voice input users can struggle to activate the link. Voice dictation is important when considering consistent labelling, also.
The best method to remediate this is to treat the logo like the "Home Dashboard" link. Ensure the logo link is also on the "Home Dashboard" page, include the visible "Joomla!" text and the words "Home Dashboard" for consistency. Use aria-current="page" as the indicator that the user is on the Dashboard, as you do on the dedicated "Home Dashboard" link: (This method was originally provided in the recent accessibility audit issue report for this particular issue.)
Sorry but this is wrong. You havent understood the reported issue.