[#48378] - [6.1] Improve sidebar menu toggle accessibility (#48376)
- Pending
- Medium
- Build: 6.1-dev
- # 48378
- Diff
- N6REJ:48376
User tests: Successful: Unsuccessful:
Replace anchor element with button for sidebar menu toggle to improve semantic HTML and accessibility. Add aria-pressed attribute to indicate toggle state and aria-labelledby for better screen reader support. Update SCSS to style button elements consistently with existing anchor styling. Human: The commit message should be in the imperative mood, e.g., "Fix bug" instead of "Fixes bug" or "Fixed bug".
Pull Request resolves #48376 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
fixes the button role and accessibilty
Testing Instructions
use chrome accessibility tree to verify toggle works.
Actual result BEFORE applying this Pull Request
was treated as a link only.
Expected result AFTER applying this Pull Request
properly meets a11y toggle specs
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
there is no need to add useless css
Before this PR
With this PR
I have tested this item 🔴 unsuccessfully on 1a03bca
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48378.
I have tested this item 🔴 unsuccessfully on 1a03bca
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48378.
| Labels |
Added:
NPM Resource Changed
PR-6.1-dev
|
||
Before this PR
## With this PR
thanks for that.. I've reverted the .css changes
But wouldn't it be better if all icons were centered?
@brianteeman thanks for that.. I've reverted the .css changes
But wouldn't it be better if all icons were centered?
Before this PR
thanks for that.. I've reverted the .css changes
Before this PR
thanks for that.. I've reverted the .css changes
But wouldn't it be better if both icons were centered?
@N6REJ Please fix css coding style:
https://github.com/joomla/joomla-cms/actions/runs/33954530021/job/101275559328?pr=48378