Updates Requested PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar mmustafasenoglu
mmustafasenoglu
30 Aug 2026

Fixes #48330

The tag list view filters articles by regardless of user permissions, so unpublished/hidden articles never appear even for users with edit rights.

This changes the state filter to allow (unpublished + published) when the user has permission on , matching the pattern already used in .

avatar mmustafasenoglu mmustafasenoglu - open - 30 Aug 2026
avatar mmustafasenoglu mmustafasenoglu - change - 30 Aug 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2026
Category ⇒ com_tags Front End
avatar brianteeman
brianteeman - comment - 30 Aug 2026

There was a reason you were given a template to complete when you submitted the PR. It was not for fun. Please update your PR with the relevant information - you can find the template here https://github.com/joomla/joomla-cms/blob/5.4-dev/.github/PULL_REQUEST_TEMPLATE.md

avatar brianteeman
brianteeman - comment - 30 Aug 2026

It is expected that everyone who submits a pull request checks their work before submitting

avatar mmustafasenoglu mmustafasenoglu - change - 30 Aug 2026
Labels Added: PR-5.4-dev
avatar CSGoat0
CSGoat0 - comment - 2 Sep 2026

Hi @mmustafasenoglu, thanks for your PR.
I don't think this is the right way of fixing this issue, checking for com_content permissions in the tag model that could be used by other components will lead a user that have core.edit permission on just the com_content to access the states of the rest of the components too which is absolutely wrong.

tag.state is a flat value that is used in the query of other components too according to what I've found.
So, working on this issue will require some engineering plan to get to a valid solution.

avatar mmustafasenoglu
mmustafasenoglu - comment - 3 Sep 2026

Thank you for the detailed feedback. You are right that checking com_content permissions in the shared tag model could expose unpublished states from other components. I also apologize for submitting the PR without completing the required template and without catching this issue beforehand. Since the current approach is insufficient, I will not update the PR with misleading information and will leave the engineering work to be addressed properly.

avatar mmustafasenoglu mmustafasenoglu - close - 3 Sep 2026
avatar mmustafasenoglu mmustafasenoglu - change - 3 Sep 2026
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-09-03 08:35:08
Closed_By ⇒ mmustafasenoglu
Labels Added: Updates Requested

Add a Comment

Login with GitHub to post a comment