[#48343] - [5.4] [cli] AddUserCommand with password validation
- Closed
- 3 Sep 2026
- Medium
- Build: 5.4-dev
- # 48343
- Diff
- alikon:patch-7
User tests: Successful: Unsuccessful:
Updated the AddUserCommand to include password confirmation like in site/admin application.
Pull Request resolves #37629.
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
use the site/admin validation in cli
Testing Instructions
create a user using the cli
php cli/joomla.php user:add
Actual result BEFORE applying this Pull Request
no validation on password
Expected result AFTER applying this Pull Request
password validation as per site/admin form validation
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
wondering why this pr is not running the full ci/cd pipeline
because it is in Draft status ?
When you enter an invalid usergroup eg 9 then the error is displayed immediately
But if you enter an invalid password you dont get the error message until the very end
Otherwise it works as expected
| Labels |
Added:
PR-5.4-dev
|
||
if you enter an invalid password you dont get the error message until the very end
fixed
I have tested this item ✅ successfully on b7caaaf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48343.
I have tested this item ✅ successfully on b7caaaf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48343.
its a bugfix not a feature
This PR looks like a new feature to me regarding its implementation. I've discussed it with a few other maintainers and they agree with me.
can you clarify why it looks like a new feature ?
Before the pr you can create a user with a password that don't satisfy the password rules that are present across all the system
This PR looks like a new feature to me regarding its implementation. I've discussed it with a few other maintainers and they agree with me.
can you clarify why it looks like a new feature ? Before the pr you can create a user with a password that don't satisfy the password rules that are present across all the system
Well, it fixes a bug, but it does that by adding new functionality. I will put it on the agenda for the weekly maintainers meeting and ask again. Personally I am in the middle of the 2 chairs.
I've restored @brianteeman test result in the issue tracker as the later commits which have invalidated the test counter were just code style changes (empty lines) and a clean branch update.
@alikon Thank you for your contribution to fixing this issue, which was opened in 2022.
We discussed this PR in the maintainer meeting. It could be considered either a bug fix or a new feature. In the end, we decided to treat it as a feature.
Could you please rebase the PR against the 6.3-dev branch?
How a bug fix can be considered a feature, leaves me extremely perplexed, and still no explanation has been provided as to why it is considered a feature, the only clear thing is that it will probably be released in about 9 months, absurd
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-09-03 06:20:18 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
Feature
|
||
wondering why this pr is not running the full ci/cd pipeline