[#4833] - [fix] Inconsistency on list view output when 'no results' are available at backend
- Closed
- 29 Oct 2014
- Medium
- Build: staging
- # 4833
- Diff
- manojLondhe:listviews
User tests: Successful: Unsuccessful:
[fix] Inconsistency on list view output when 'no results' are available at backend
This is how com_content shows output when no results
This is how com_users shows output when no results
After patch: This is how com_users shows output when no results
Fixed this for
com_contact
com_languages
com_menus
com_newsfeeds
com_users
Votes
jissues-bot
- | Labels |
Added:
?
|
||
After the patch I still get the column headers etc for com_contacts
On 18 October 2014 11:52, Brian Teeman brian@teeman.net wrote:
How do you get com_users with no users?
On 18 October 2014 11:48, Manoj L notifications@github.com wrote:
[fix] Inconsistency on list view output when 'no results' are available
at backendThis is how com_content shows output when no results
[image: com_content]
https://cloud.githubusercontent.com/assets/1375006/4689291/848bdc64-56b3-11e4-80f9-1fc537bbdbb2.pngThis is how com_users shows output when no results
[image: com_users]
https://cloud.githubusercontent.com/assets/1375006/4689292/8e314f6a-56b3-11e4-91f1-eb8378c1a8fd.pngAfter patch: This is how com_users shows output when no results
[image: com_users_after]
https://cloud.githubusercontent.com/assets/1375006/4689293/d7ca5338-56b3-11e4-8240-15acc2356ddd.pngFixed this for
com_contact com_languages com_menus com_newsfeeds com_users
You can merge this Pull Request by running
git pull https://github.com/manojLondhe/joomla-cms listviews
Or view, comment on, or merge it at:
#4833
Commit Summary
- [fix] Inconsistency on list view output when 'no results' are available at backend
File Changes
- M administrator/components/com_contact/views/contacts/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-0 (289)
- M administrator/components/com_content/views/articles/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-1 (1)
- M administrator/components/com_languages/views/languages/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-2 (238)
- M administrator/components/com_languages/views/overrides/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-3 (119)
- M administrator/components/com_menus/views/menus/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-4 (202)
- M administrator/components/com_newsfeeds/views/newsfeeds/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-5 (276)
- M administrator/components/com_users/views/groups/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-6 (135)
- M administrator/components/com_users/views/levels/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-7 (147)
- M administrator/components/com_users/views/users/tmpl/default.php https://github.com/joomla/joomla-cms/pull/4833/files#diff-8 (266)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/4833.patch
- https://github.com/joomla/joomla-cms/pull/4833.diff
—
Reply to this email directly or view it on GitHub
#4833.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
How do you get com_users with no users?
=> by searching for user that doesn't exist ;)
Woops - I applied the patch on one site and tested on another
So I have tested all core components and they are all great
The only ones left to do now are Module Manager, Plugin Manager, Template Manager
OK. Cool...
Checking for remaining ones now...
For those there are checks [and messages pushed] in related view.html files, should I remove those checks from there and add in corresponding layout [default.php] files?
twsnikhil
- 
aniket19491
-
OK.
Changed - com_installer, com_modules, com_plugins, com_templates as well :)
How do you get com_users with no users?
Or use the filter in Search tools. Filter on empty group or registered more than a year ago.
vijaykhollam
- 
2 files have to be updated to staging to be able to merge:
Sorry, but I didn't get which 2 files?
@infograf768 what needs to be updated before this can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4833.
3 files now:
articles/tmpl/default.php
newsfeeds/tmpl/default.php
styles/tmpl/default.php
@infograf768 Those 3 files are already included in the set of changed files -
administrator/components/com_contact/views/contacts/tmpl/default.php
administrator/components/com_content/views/articles/tmpl/default.php
administrator/components/com_languages/views/languages/tmpl/default.php
administrator/components/com_languages/views/overrides/tmpl/default.php
administrator/components/com_menus/views/menus/tmpl/default.php
administrator/components/com_newsfeeds/views/newsfeeds/tmpl/default.php
administrator/components/com_users/views/groups/tmpl/default.php
administrator/components/com_users/views/levels/tmpl/default.php
administrator/components/com_users/views/users/tmpl/default.php
administrator/components/com_installer/views/manage/tmpl/default.php
administrator/components/com_installer/views/manage/view.html.php
administrator/components/com_modules/views/modules/tmpl/default.php
administrator/components/com_modules/views/modules/view.html.php
administrator/components/com_plugins/views/plugins/tmpl/default.php
administrator/components/com_plugins/views/plugins/view.html.php
administrator/components/com_templates/views/styles/tmpl/default.php
administrator/components/com_templates/views/styles/view.html.php
administrator/components/com_templates/views/templates/tmpl/default.php
administrator/components/com_templates/views/templates/view.html.php
I do not think you understand: the files are NOT in sync with staging, therefore as stated just below:
"We can’t automatically merge this pull request. "
@manojLondhe There is a conflict between your change and some recent changes made in the staging branch. Most likely it's because there was some codestyle fixes lastly.
You need to update your branch and solve those conflicts manually since Git can't automatically decide what to keep.
If you don't know how to do that, just say it. I can do it when merging. But it's a bit more work for us maintainers.
Ah! Ohk!
No problem... I will do it and push changes soon...
@infograf768 please close this and refer to #4956
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-29 14:49:59 |
How do you get com_users with no users?
On 18 October 2014 11:48, Manoj L notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/