RTC Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
27 Aug 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Check the Options in list, checkboxes and radio fields. They must be unique, otherwise it is not possible to select a single option.

Testing Instructions

Make custom fields. In radio, checkboxes and list fields you have to add options (text - value pair).
Add options but leave the value empty or write the same value

example: for Articles:
grafik

Actual result BEFORE applying this Pull Request

The field is stored correctly but when you want to use it in an article, there is only one option.

Expected result AFTER applying this Pull Request

The field is not stored but an error message is displayed:
grafik

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

cdb765e 27 Aug 2026 avatar chmst oops
avatar chmst chmst - open - 27 Aug 2026
avatar chmst chmst - change - 27 Aug 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2026
Category ⇒ Administration com_fields Language & Strings
avatar chmst chmst - change - 27 Aug 2026
The description was changed
avatar chmst chmst - edited - 27 Aug 2026
1720621 27 Aug 2026 avatar chmst cs
avatar chmst chmst - change - 27 Aug 2026
Labels Added: Language Change bug PR-5.4-dev
avatar brianteeman
brianteeman - comment - 27 Aug 2026

This PR prevents you saving a NEW field or saving an edited field which uses the same value.

Should there be some sort of check/fix/notification for existing fields that do not have unique values? Not sure myself I am just asking the question

avatar QuyTon QuyTon - test_item - 27 Aug 2026 - Tested successfully
avatar QuyTon
QuyTon - comment - 27 Aug 2026

I have tested this item ✅ successfully on 2f63300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar QuyTon
QuyTon - comment - 27 Aug 2026

I have tested this item ✅ successfully on 2f63300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar brianteeman brianteeman - test_item - 27 Aug 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Aug 2026

I have tested this item ✅ successfully on 2f63300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar brianteeman
brianteeman - comment - 27 Aug 2026

I have tested this item ✅ successfully on 2f63300


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar richard67 richard67 - alter_testresult - 27 Aug 2026 - QuyTon: Tested successfully
avatar richard67 richard67 - alter_testresult - 27 Aug 2026 - brianteeman: Tested successfully
avatar richard67 richard67 - change - 27 Aug 2026
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 27 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar richard67
richard67 - comment - 27 Aug 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48328.

avatar chmst
chmst - comment - 27 Aug 2026

This PR prevents you saving a NEW field or saving an edited field which uses the same value.

Both. If a field exists already with same values in options it is wrong and cannot be used. Users will see this as a bug.

avatar chmst
chmst - comment - 27 Aug 2026

This PR prevents you saving a NEW field or saving an edited field which uses the same value.

Both. If a field exists already with same values in options it is wrong and cannot be used. Users will see this as a bug. I don't know if a warning is necessary when this bug occurs.

avatar muhme muhme - change - 28 Aug 2026
Labels Added: RTC
avatar muhme
muhme - comment - 28 Aug 2026

✅ Final test before merge with JBT

  • Seen before PR
    • Article fields with multiple values – as named checkboxes, radio, list – with identical values only one of the fields is shown on article
    • This problem doesn't exist for other field types as either they have no multiple values or
      • for subform the yellow warning 'Duplicate subform fields were removed. Each field can only be used once.' and field was removed
  • Applied PR with Patch Tester
    • Seen red error 'The option values must be unique.' on 'Save' or 'Save & Close' for checkboxes, radio, list with duplicate values
    • Seen red error 'The option values must be unique.' on 'Save' or 'Save & Close' for checkboxes, radio, list with duplicate values
    • With unique values checkboxes, radio, list can be saved and used in article
    • With one empty value checkboxes, radio, list can be saved and used in article
    • Already existing checkboxes, radio, list fields with duplicates values are still shown once for article
      • As already commented, users are not notified of duplicate values in existing custom fields. Could that be part of the health checker?
    • No unusual Joomla or PHP log messages
avatar muhme muhme - change - 28 Aug 2026
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-08-28 04:39:31
Closed_By ⇒ muhme
avatar muhme muhme - close - 28 Aug 2026
avatar muhme muhme - merge - 28 Aug 2026
avatar muhme
muhme - comment - 28 Aug 2026

Thank you very much @chmst for your contribution. Thank you @QuyTon for your support and testing. Thank you @brianteeman for testing.

Add a Comment

Login with GitHub to post a comment