[#48327] - [5.4] Template Override Count - fix
- Fixed in Code Base
- 30 Aug 2026
- Medium
- Build: 5.4-dev
- # 48327
- Diff
- brianteeman:override_count
User tests: Successful: Unsuccessful:
Pull Request resolves #47549 .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
The count of overrides to check displayed in the quickicon may not match the total number of overrides that can be checked in the template manager. This is because the count includes all templates but the tempate manager only displays templates that are enabled. This causes confusion "where are my overrides" and can result in a lack o9f trust in the information displayed.
This change joins #__template_overrides with #__extensions and restricts the results to enabled extensions of type template.
Testing Instructions
If your test install doesnt already have any "overrides to check" then you need to simulate it by adding records into your #__template_overrides db table.
Assuming a CLEAN install
- Create a child template called test - this will actually create a new template called cassiopeia_child
- In the extension manager take a not of the id for each template
3. Run this sql - update #_ with your own db prefix and use the correct ID for each template
INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`) VALUES
(1, 'cassiopeia_child', 'L2h0bWwvY29tX2NvbnRlbnQvY2F0ZWdvcnkvYmxvZy5waHA=', 249, 0, 'Joomla Update', 0, '2023-07-11 21:10:59', '2024-04-18 18:38:54'),
(2, 'cassiopeia', 'L2h0bWwvbW9kX2FydGljbGVzL2RlZmF1bHRfdGl0bGVzLnBocA==', 243, 0, 'Joomla Update', 0, '2026-03-31 16:07:44', '2026-03-31 16:07:44');
- On your control panel the count should now display 2
- In the extension manager disable the child template
Actual result BEFORE applying this Pull Request
The count of overrides to check is 2
Expected result AFTER applying this Pull Request
The count of overrides to check is 1
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
PR-5.4-dev
|
||
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+9+39).
Thank you!
Regards,
Peter
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+8+39).
Thank you!
Regards,
Peter
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+8+19).
Thank you!
Regards,
Peter
@peterhulst Please mark your test here. Thanks!
@peterhulst Please mark your test result here. Thanks!
Hello,
I have checked the PR succesfully. Before: 50 overrides, after 39 overrides (12+9+39).
Thank you!
Regards, Peter
@peterhulst I'm almost sure that it is not the first time that I ask you to mark your test result in the issue tracker. Got to https://issues.joomla.org/tracker/joomla-cms/48327 , use the blue "Test this" button at the top left corner, select your test result and submit.
I have tested this item ✅ successfully on 154395e
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+8+39).
Thank you!
Regards,
Peter
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
I have tested this item ✅ successfully on 154395e
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+8+39).
Thank you!
Regards,
Peter
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
I have tested this item ✅ successfully on 154395e
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+8+19).
Thank you!
Regards,
Peter
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
Hello,
I have checked the PR succesfully. Before: 50 overrides, after 39 overrides (12+9+39).
Thank you!
Regards, Peter@peterhulst I'm almost sure that it is not the first time that I ask you to mark your test result in the issue tracker. Got to https://issues.joomla.org/tracker/joomla-cms/48327 , use the blue "Test this" button at the top left corner, select your test result and submit.
@richard67 Sorry. I looked seriously for that button in GITHUB, but could not found it. Now I see it: it is at ...issues.joomla.org.
--> there are two places where the PR is mentioned and at GITHUB the "Test this" button is not visible.
I have tested this item ✅ successfully on 154395e
Applied the sql to the sdb,
two overwrites appeared , Error => two after disable
After apllied patch only one override was shown
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
I have tested this item ✅ successfully on 154395e
Applied the sql to the sdb,
two overwrites appeared , Error => two after disable
After apllied patch only one override was shown
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on b8d1e4b
Final test before merge:
I've verified the issue and tested the fix from this PR with MySQL and PostgreSQL.
For testing I have started with 5.4.8 plus the fix for the override creation, see https://manual.joomla.org/updates/53-54/known-issues/5.4.8/ .
I have created 2 child templates and for each of the parent and the 2 child I have created an override for the "components/com_content/tmpl/category/default_articles.php" file because that has changed since 5.4.8 and should create a changed override file when updating to a current nightly or the patched package for this PR.
Then I have disabled one of the child templates in the extensions manager.
Then I have updated to the latest nightly with upload & update (and in one test to the patched package of this PR using the custom update URL created by Drone).
After the update I have toggled the enabled status for child templates in the extensions manager for testing this PR.
Interesting detail: When a (child) template is disabled in the extensions manager before the update, the changed override is not detected during the update. So when you enable that (child) template again after the update, no override warning is shown or counted. That will happen with the next core update.
This is the case without and with this PR, so that PR does not change anything regarding that, and it also doesn't break anything else.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
I have tested this item ✅ successfully on b8d1e4b
Final test before merge:
I've verified the issue and tested the fix from this PR with MySQL and PostgreSQL.
For testing I have started with 5.4.8 plus the fix for the override creation, see https://manual.joomla.org/updates/53-54/known-issues/5.4.8/ .
I have created 2 child templates and for each of the parent and the 2 child I have created an override for the "components/com_content/tmpl/category/default_articles.php" file because that has changed since 5.4.8 and should create a changed override file when updating to a current nightly or the patched package for this PR.
Then I have disabled one of the child templates in the extensions manager.
Then I have updated to the latest nightly with upload & update (and in one test to the patched package of this PR using the custom update URL created by Drone).
After the update I have toggled the enabled status for child templates in the extensions manager for testing this PR.
Interesting detail: When a (child) template is disabled in the extensions manager before the update, the changed override is not detected during the update. So when you enable that (child) template again after the update, no override warning is shown or counted. That will happen with the next core update.
This is the case without and with this PR, so that PR does not change anything regarding that, and it also doesn't break anything else.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48327.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-30 14:11:17 |
| Closed_By | ⇒ | richard67 |
Thanks @brianteeman for this PR, and @peterhulst and @ThomasFinnern for testing.
Thanks
Hello,
I have checked the PR succesfully.
Before: 50 overrides, after 39 overrides (12+9+39).
Regards,
Peter