[#48234] - [5.4] Make filter button visible in articles category list
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 48234
- Diff
- drmenzelit:filter-tags
User tests: Successful: Unsuccessful:
Pull Request resolves # .
Issue mentioned in the German Forum: https://forum.joomla.de/thread/23844-schlagwortfilter-in-katergorieliste
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
PR #47774 removed the onchange function from filters, but missed to make the filter (submit) button visible for all kind of filters. Filter by Tags or Months didn't work anymore.
ATTENTION: filter by months is broken, but that is unrelated with this this or the mentioned PR.
Testing Instructions
Create articles with tags.
Create a menu item of type category list and display the filter by tags.
Actual result BEFORE applying this Pull Request
Filter doesn't work.
Expected result AFTER applying this Pull Request
The filter button is visible and you can submit the selected tag -> filter works
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
richard67
- | Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 63fa661
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
I have tested this item ✅ successfully on 63fa661
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
I have tested this item ✅ successfully on 63fa661
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
I have tested this item ✅ successfully on 63fa661
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48234.
Thank you, in my opinion, the tags filter is not correct as select list, but this is not related here.
From a11y point of view - predictable - we should have all filters as textfields or all filters as selectlist.
The message displayed when you have no articles matching the tag filter is incorrect - but thats out of scope for this PR